Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro for defining the type of a schedule. #146

Merged
merged 7 commits into from
Nov 25, 2022
Merged

Macro for defining the type of a schedule. #146

merged 7 commits into from
Nov 25, 2022

Conversation

Anders429
Copy link
Owner

Fixes #145.

This adds a Schedule! macro, used to define the type of a schedule. The capitalization of this macro follows the pattern being established by #141.

Also fixes an internal issue with some macros doc tests being run multiple times. Not a big issue, but this ensures that when one of these macro tests fails, it will only be indicated in the test results a single time.

@Anders429 Anders429 added C - Enhancement Category: New feature or request. P - Low Priority: Not particularly urgent. F - rayon Feature: Parallel processing through the rayon library. A - Scheduling Area: Parallel scheduling of systems. V - Minor Breaking Change Versioning: Requires a minor bump according to semver. labels Nov 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

Merging #146 (e6953f9) into dev (fda6fe7) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##              dev     #146      +/-   ##
==========================================
- Coverage   94.81%   94.81%   -0.01%     
==========================================
  Files          73       73              
  Lines       10223    10222       -1     
==========================================
- Hits         9693     9692       -1     
  Misses        530      530              
Impacted Files Coverage Δ
src/registry/debug/sealed.rs 0.00% <0.00%> (ø)
src/system/mod.rs 0.00% <ø> (ø)
src/system/schedule/mod.rs 71.34% <ø> (ø)
src/world/mod.rs 100.00% <ø> (ø)
src/registry/sealed/storage.rs 99.92% <100.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Anders429
Copy link
Owner Author

Miri failures are definitely a case of #82. As mentioned in that thread, rayon#952 indicates that this is actually caused by rayon itself, and has actually not caused any issues in practice.

Not sure if the best move is to just disable rayon in the miri tests or what. The problem only seems to occur in the schedule tests. For now, I'll just leave it and merge this PR.

@Anders429 Anders429 merged commit 9d2168d into dev Nov 25, 2022
@Anders429 Anders429 deleted the schedule branch November 25, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A - Scheduling Area: Parallel scheduling of systems. C - Enhancement Category: New feature or request. F - rayon Feature: Parallel processing through the rayon library. P - Low Priority: Not particularly urgent. V - Minor Breaking Change Versioning: Requires a minor bump according to semver.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants