Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for new hOn login #29

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Update for new hOn login #29

merged 2 commits into from
Aug 14, 2024

Conversation

addshore
Copy link
Contributor

Andre0512/hon#230

It looks like the first URL gives us a different URL back, that is also relative.
This URL takes us to a NEW login page, so I force us back to the old one for now.
It also looks like there used to be more redirects, and now there are less?

Anyway, this code should work for both the OLD and NEW auth methods as far as I can tell

@addshore
Copy link
Contributor Author

Tested using my login and the example in the docs to list my appliances, and it correctly lists my refrigerator

@zawadzkipiter
Copy link

wow this works! @addshore You are our hero!

@addshore
Copy link
Contributor Author

addshore commented Jul 10, 2024

wow this works! @addshore You are our hero!

Any idea how to fold this into a working HA integration? :D

@edmund-1
Copy link

Interesting, anyone can approve, but needs special permissions to merge to base branch. Not sure if @Andre0512 added anyone except him with merge permissions.

@addshore
Copy link
Contributor Author

Let's hope @Andre0512 makes an appearance in that case!

zawadzkipiter added a commit to zawadzkipiter/hon that referenced this pull request Jul 10, 2024
fix for HA "Can't login" based on:
Andre0512/pyhOn#29
@roelofz
Copy link

roelofz commented Jul 10, 2024

I also experienced problems today with the HON integration. I read here about pyhon, but I don't know what to do with it. I'm running HA in a container, so maybe this is not a solution for me.
If it is, how to enable / install this?

@addshore
Copy link
Contributor Author

@roelofz take a look at Andre0512/hon#230

@roelofz
Copy link

roelofz commented Jul 10, 2024

So I need to wait untill https://github.com/Andre0512/hon/ has updated his package, the link describes the issue, but I am not able to see what code needs to be modified on what place. Too difficult for (am not a coder, so maybe noob behaviour)...

@DavidMW38
Copy link

So I need to wait untill https://github.com/Andre0512/hon/ has updated his package, the link describes the issue, but I am not able to see what code needs to be modified on what place. Too difficult for (am not a coder, so maybe noob behaviour)...

So, I was struggling with this too, my system wouldn't let me use this fork (HACS said the repo wasn't configured correctly), and couldn't find PyhOn-0.17.5 for some reason (only 0.17.4). But I solved the issue by deleting my HOn config and integration, removing the HOn HACS download, restarting HA, then installing this version (available in HACS too) instead (https://github.com/gvigroux/hon.git), restarting HA one more time and then adding the HOn integration to HA. My login details worked first time, and my devices and entities work again 🥳

@roelofz
Copy link

roelofz commented Jul 14, 2024

It works! Thanks mate!

@DavidMW38
Copy link

It works! Thanks mate!

No worries 👍 Glad it worked for you too.

I don't know why my system said PyhOn-0.17.5 doesn't exist, or why I couldn't convince it to use this repository (even a downloaded & unzipped version of it), but swapping to this integration works so I'm happy again ☺️

...Now, if only solving the Smart Life/Tuya integration auth problem (that has "apparently" already been fixed 🤷‍♂️) was so easy 😮‍💨 lol

@roelofz
Copy link

roelofz commented Jul 15, 2024

I have no idea how to install Pyhon, nor do I know if it is installed. I only removed the old package and installed the new one, with restarts in between.

@Borty97
Copy link

Borty97 commented Jul 25, 2024

I approved it. I do not know if someone else needs to approve it too (I supose). Hope I helped

@Andre0512
Copy link
Owner

Thanks for your work! Sorry for the late response...

@Andre0512 Andre0512 merged commit 59e3d99 into Andre0512:main Aug 14, 2024
1 check passed
Andre0512 pushed a commit to Andre0512/hon that referenced this pull request Aug 14, 2024
fix for HA "Can't login" based on:
Andre0512/pyhOn#29
@addshore
Copy link
Contributor Author

Thanks for your work! Sorry for the late response...

Haha, no problem :)
Thanks for reappearing!

@addshore addshore deleted the updatedLogin branch August 15, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants