Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom BoxShadow instead of just color #28

Merged
merged 2 commits into from
Feb 19, 2019
Merged

add custom BoxShadow instead of just color #28

merged 2 commits into from
Feb 19, 2019

Conversation

quetool
Copy link
Contributor

@quetool quetool commented Jan 31, 2019

Just a little change to add custom BoxShadow

@AndreHaueisen
Copy link
Owner

Hi @quetool
You make a valid point. I think we can remove the shadowColor property for the sake of simplicity and leave only boxShadow.

If you can update it will be great, if not I can do it in a few weeks.
This should be included in the next release together with some IOS bug fixes.

Thanks for the feedback and help.
Cheers.

@quetool
Copy link
Contributor Author

quetool commented Feb 1, 2019

Hi @AndreHaueisen, thanks for your reply. Sure, I'll do in a moment! Thanks!

@quetool
Copy link
Contributor Author

quetool commented Feb 1, 2019

Did it! Thanks for your repo, it is just great!

@facundomedica
Copy link

@AndreHaueisen this looks good to me too, could you please merge it? Thanks!

@AndreHaueisen AndreHaueisen merged commit 4fb1c73 into AndreHaueisen:master Feb 19, 2019
@AndreHaueisen
Copy link
Owner

Sorry about the delay. Have a lot going on these days.
Thanks for the help guys.

@quetool quetool deleted the patch-1 branch February 19, 2019 12:09
@quetool
Copy link
Contributor Author

quetool commented Feb 19, 2019

@AndreHaueisen thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants