⚡ Two small performance improvements #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should reduce the number of `growSlice` operations resulting in some minor speedups. The number was determined by looking at the average size of keys.
Instead of doing replace, a `FindStringSubmatch` is actually all that's needed. It is just a minor change, but still reduces the runtime by a few tens of milliseconds. See #47 for a similar improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡ Grow strings.Builder at beginning
This should reduce the number of
growSliceoperations resulting in some minor speedups. The number was determined by looking at the average size of keys.⚡ More efficient Regex umbr.Equals
Instead of doing replace, a
FindStringSubmatchis actually all that's needed. It is just a minor change, but still reduces the runtime by a few tens of milliseconds.See #47 for a similar improvement.