first commit for Edushare #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for template-bhai failed.
|
Karthik-315
reviewed
Aug 2, 2022
| </head> | ||
|
|
||
| <body> | ||
| <nav> |
There was a problem hiding this comment.
Wrap the title and the navbar inside of a header tag. Have the title outside the <nav> tag.
Karthik-315
reviewed
Aug 2, 2022
| <img src="assets/Logo.svg" alt="Edushare Logo" class="edushare-logo"> | ||
| <button class="sign-in-button">Sign In</button> | ||
| <ul class="navbar-desktop"> | ||
| <a href="#"> |
There was a problem hiding this comment.
Have the <li> tag wrap around the anchor tag.
There was a problem hiding this comment.
Also, add a tiny horizontal margin or gap between links.
|
On a general note, the HTML and CSS look unformatted in places, so make sure to run prettier in your code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the E-learning template.