Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep a reference to Tuning and Raycaster in vehicles #3

Merged
merged 1 commit into from
Nov 10, 2014
Merged

Keep a reference to Tuning and Raycaster in vehicles #3

merged 1 commit into from
Nov 10, 2014

Conversation

gepa21
Copy link
Contributor

@gepa21 gepa21 commented Oct 24, 2014

... so garbage collector will not collect/dispose them while being used

... so garbage collector will not collect/dispose them while being used
@gepa21 gepa21 mentioned this pull request Oct 24, 2014
AndresTraks added a commit that referenced this pull request Nov 10, 2014
Keep a reference to Tuning and Raycaster in vehicles
@AndresTraks AndresTraks merged commit 8069a1a into AndresTraks:master Nov 10, 2014
@AndresTraks
Copy link
Owner

All vehicle classes have been rewritten as C++/CLI managed classes.

@gepa21 gepa21 deleted the pull_request branch November 14, 2014 12:12
@gepa21
Copy link
Contributor Author

gepa21 commented Nov 14, 2014

That's awesome :)

I pulled the changes and did some testing.
Everything seemed to work ok physics-wise but i noticed that the wheels were not turning...
so i did some digging and found that for the calculation it chooses RightAxis instead of ForwardAxis.

I fixed that and everything seems to work great now. The fix is here #5

@gepa21
Copy link
Contributor Author

gepa21 commented Nov 14, 2014

i fixed another problem... when i compiled in Release mode (sharpdx) it would crash immediately.
I tracked the problem in the "delete info;" of the _fixedBody's info in RaycastVehicle static constructor.
I updated pull request #5 to include this fix.

@AndresTraks
Copy link
Owner

Ah, I merged the pull request, but didn't see the second part.
The RigidBodyConstructionInfo should be deleted, because it isn't used any longer. There must be something else wrong there. I'll investigate..
The axis fix is good, thanks!

@gepa21
Copy link
Contributor Author

gepa21 commented Nov 14, 2014

actually in my branch i completely removed fixedbody, but RigidBodyConstructionInfo has a destructor so it will be deleted when it's not referenced anymore

@AndresTraks
Copy link
Owner

That's true, but a preemtive Dispose is always good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants