Update Message.js to catch hidden story share case #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catch case when the story share is hidden because of a private account. When not catched it throws an error.
dcts
commented
Jan 19, 2021
src/structures/Message.js
Outdated
| this.storyShareData = { | ||
| author: data.story_share.message === 'No longer available' ? null : this.client._patchOrCreateUser(data.story_share.media.user.pk, data.story_share.media.user), | ||
| sourceURL: data.story_share.message === 'No longer available' ? null : data.story_share.media.image_versions2.candidates[0].url | ||
| if (data.story_share.message === 'No longer available' || data.story_share.message.startsWith("This story is hidden because")) { |
There was a problem hiding this comment.
that is the message data object that is causing the error (fixed with my code):
fix bug preventing valid story to be sent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves issue #45.
It catches the case of a story share that is hidden. The message data in this case looks like this:
We could also extract the handle of the story that was hidden from the message string and save it in the
this.storyShare.authorvariable. I am open for suggestions.@Androz2091 Let me know what you think of this.