Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase BUFSZIZE to (1024*10). Send INFO text to stderr instead of stdout. #4

Closed
wants to merge 1 commit into from

Conversation

koppi
Copy link

@koppi koppi commented Apr 23, 2016

Closes #2 .

@Andy1978
Copy link
Owner

Using stderr to show verbose info messages is IMHO a very bad idea. stderr should only be used if there is an error and the program returns != 0.

@koppi
Copy link
Author

koppi commented Apr 23, 2016

Makes sense.

My first gcoder alpha test user @ArcEye came up with a quick fix which I would like to propose for inclusion in hf2gcode.c: prepend the info messages with a semi-colon to make the LinuxCNC interpreter happy – see QGCoder/qgcoder#5 (comment) .

What do you think?

@Andy1978
Copy link
Owner

@koppi : As i already wrote, If you want to supress unneeded infos use "hf2gcode -m -q"
But I consider to change hf2gcode that the additional infos are only included if using "-v" or I always use comments for info messages.

@Andy1978
Copy link
Owner

I've removed --quiet which is now default, additional infos has to be enabled with "--verbose"

@koppi
Copy link
Author

koppi commented Apr 23, 2016

Thank's a lot!

@koppi koppi closed this Apr 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants