Add rectangular trapezoidal shape of electron beam #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxThevenet
reviewed
Feb 14, 2022
| z = rectan_trapezoid(n_part,a=z_c-length/2,b=z_c+length/2,h1=head_current) | ||
| else: | ||
| raise NotImplementedError('Noise reduction not implemented for `trapezoidal` profile.') | ||
| return z |
There was a problem hiding this comment.
Here is an easy way for smoothing your profile (in this case, you do a convolution of the z trapezoidal profile with a Gaussian of size length/10). This would keep the number of particles and the total charge constant, but smoothen the function (affecting a bit the heights). Could you give it a try, and see if it gives what you want? You could use this for your simulations, but I am not saying this should be merged in Wake-T, Angel may prefer to keep the consistency.
Suggested change
| return z | |
| z += np.random.normal(loc=0., scale=length/10, size=n_part) | |
| return z |
@AngelFP any thought?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.