Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-754: Withdraw beneficiary dropdown from subgraph #2382

Merged
merged 496 commits into from
Sep 29, 2023

Conversation

ap-justin
Copy link
Collaborator

@ap-justin ap-justin commented Sep 19, 2023

Ticket(s):

Explanation of the solution

  • use subgraph to get list of beneficiary endowments

  • remove post-submit checks for beneficiary endow, as bene options are already filtered

    • not closed
    • not the withdrawer
    • if charity, bene endowtype = charity
    • if ast, bene endowType = charity,normal
    • future ( if DAF ) - get from list of daf approved endowments
  • admin/1/withdraw search for test (AST)

image

*admin/2/withdraw search for test - no result as endow:2 is charity and can't withdraw to an ast
image

Instructions on making this work

  • run yarn or yarn install to install npm dependencies
  • run yarn run test --watchAll to verify all tests still pass
  • (optional) run yarn run build to verify the build passes
  • run yarn start to start the webapp

UI changes for review

When major UI changes are introduced with a PR, please include links to URLS to compare or screenshots demonstrating the difference and notify on design changes

SovereignAndrey and others added 30 commits February 9, 2023 11:15
* last few angel giving rebanding changes

* fix white text
* non-sequential use of heading tags >> p

* aria-labels added to more buttons and links

* org btn using grey color text for better contrast/legibility

* default to dark theme

* Ignore system theme when checking if dark

* add system theme check back in

---------

Co-authored-by: Nenad Misic <nenad@angelprotocol.io>
* non-sequential use of heading tags >> p

* aria-labels added to more buttons and links

* org btn using grey color text for better contrast/legibility

* default to dark theme

* Ignore system theme when checking if dark

* add system theme check back in

* fix profile title

---------

Co-authored-by: Nenad Misic <nenad@angelprotocol.io>
* more AP > AG branding changes found

* lint
* change copy - #860pw6rt2

* add mor social urls - #860pw6p6j

* dont edit contract email - #860pw6nvq

* remove city field (depreciated) - #860pw6wqb

* SEO title for edit page - #860pw6ur5

* char limits & set char count on init

* empty strings should not be validated

* remove hq_city(entirely) & contract_email(just not updatable)
* remove view layer

* remove admin mobile portal

* use common layout on all admin types

* update mobile nav spacing

* nav wrapper

* refactor admin resource fetcher and context

* edit profile: diff between disconected and unauthorized

* reuse config from resources

* remove never

* add settings page

* prep: font and paddings

* settings dashboard

* strategy editor routes

* cherry: breadcrumbs syntax

* cherry: consider end and use current on leaf route

* revert breadcrumb changes

* strategies field array

* vault selection

* prep: font and paddings

* strategy name
* open header logo in new tab/page

* use ExtLink component
* remove view layer

* remove admin mobile portal

* use common layout on all admin types

* update mobile nav spacing

* nav wrapper

* refactor admin resource fetcher and context

* edit profile: diff between disconected and unauthorized

* reuse config from resources

* remove never

* prep: font and paddings

* shared balance

* transformed balance query

* move registrar file

* cherry: remove custom tags

* custom vault query

* account tabs common

* invest options

* correct default tag

* add symbol and precisoin

* add correct symbol

* invest form

* invest wiring

* form heading

* cherry: use token-id

* text sm investor
* Donate widget (#1605)

* Add Donate/Widget page

* Rename Steps to StepsPage

* Refactor isHeadingShown

* Update donate widget route to /donate-widget

* Refactor CurrStep

* Add missing space in BtnSec style

* Add query loader scaffold to Widget

* Update BtnSec to use .btn class

* Move DonateWidget to separate /page folder (includes other refactors)

* Move DonateWidget outside the /App component

* Set light mode when opening donation widget

* Add theme setting logic to widget

* Move DonateWidget Content to separate file

* Move Kado modal to Steps & extract CurrentStep

* Refactor isHeadingShown to isFinalized

* Remove redundant WalletSuite Props

* Add widget header section

* Move profile Balances to shared components

* Update Balances to accept direction

* Add Balances to widget

* Extract Balance out of Balances into separate file

* Remove widget header stickiness

* Add footer

* Move WalletSuite to shared components

* Fix title font size in widget

* Add text styling

* Make padded-container have mx-auto on all screen widths

* Add className to Header Logo

* Move Header/Logo to components/APLogo

* Use APLogo in widget footer

* Create separate Balances for widget

* Update Balances styles on widget

* Add alignment styles

* Reduce Steps text size on mobile

* Reduce Steps width inside widget

* Move Donate steps title to just Donate page

* Set z-index of widget header to z-20

* Hide Intercom Chatbot on widget

* Fix App.test

* Refactor CoinBalances

* Remove leftover useBalances

* Remove Balances

* Update the donate widget URL format and route parameter reading logic (#1610)

* Handle null in idParamToNum

* Read endowId from query params

* Move API key check into ApiKeyChecker

* Read endowmentId from route params

* Move Endowment loading into separate loader component

* Add comment for hiding the Intercom chatbot

* Rename DonateWidget/Content to InnerComponent

* Widget page (#1613)

* Add AIF page scaffold

* Add header section of the widget config. page

* Add Views page with routes to AIF

* Add Default widget image section

* Create WidgetUrlConfigForm component

* Comment out id param assignment

* Move WidgetConfigurer to separate folder

* Create Split component

* Add state to WidgetUrlConfigForm

* Rename WidgetUrlConfigForm to WidgetUrlGenerator

* Rename components/Checkbox to CheckboxFormField

* Move Marketplace/../Checkbox to components/* folder

* Add widget URL generator scaffold

* Add 'Available currencies' span

* Rename components/Selector to SelectorFormField

* Extract Selector from SelectorFormField

* Add available currencies selector

* Add useLazyTokensQuery to fetch list of tokens

* Update useApprovedTokens to use useLazyTokensQuery

* Update config sections widths

* Add URL generator logic

* Update widths and alignments

* Update widget-example.png

* Reduce title style font size on sm:

* Add widget URL code section

* Reduce img size

* Reduce url param length

* Move useCopier to hooks/*

* Add Copy URL ability

* Add focus outline on light mode

* Move useCopier back to Copier

* Implement copy/paste this URL section

* Check the boxes on clicking labels

* Center in column on mobile

* Display unfoldAdvancedOptions when \!hideAdvancedOptions

* Add gap-4 on mobile on main screen

* Update alignment on mobile

* Add Reset changes btn

* Move BtnPrim from components/gift to components/*

* Fix donate widget URL

* Revert Copier changes

* Use VarOption where appropriate in Selector

* Use react hook form for URL generation

* Move WidgetUrlGenerator to separate folder

* Show loading ring while approved tokens are loading

* Create DenomSelector

* Add missing FormProvider

* Gray out checkbox label on disabled (#1630)

* Configure widget based on URL query params (#1639)

* Extract URL params into separate constants.ts file

* Add as const to URL_PARAMS definition

* Update how boolean URL params are appended

* Add useWidgetParams hook

* Read widget params in DonateWidget

* Update useWidgetParams result

* Hide widget text if set

* Rename Result to UrlParamValues

* Move UrlParamValues to types

* Refactor how UrlParamValues are used

* Move append to bottom of file in WidgetUrlGenerator

* Add UrlParamValues to Steps Props

* Remove hideEndowGauges

* Move main url param fields to ConfigParams type in Steps

* Use widget parameters inside the widget

* Set default gap in widget header

* Fix default widget params

* Fix liquidPercentage append to URL

* Always include fee-paying coin in tokens dropdown when donating

* Remove consloe.log

* Add full iframe for widget url (#1642)

* Fix leftover deprecated imports from aws & QueryLoader

* Revert Checkbox to Sidebar/common

* Revert BtnPrim to components/gift

* Remove widgetRoutes

* Remove WalletDetails folder

* Add Sidebar Checkbox back to index

* Make widget example responsive to selected options (#1653)

* Update WidgetConfig example title

* Move url param reading to DonateWidget

* Enable passing of props to DonateWidget

* Refactor DonateWidget to accept default query params

* Refactor how widgetSnippet is generated

* Add className prop to DonateWidget

* Add DonateWidget to WidgetConfigurer instead of image

* Remove widget example img

* Add missing className prop assignment in DonateWidget

* Fix bug in AdvancedOptions unfold logic

* Make DonateWidget responsive to changing params passed from WidgetConfigurer

* Fix DonateWidget width on WidgetConfigurer

* Fix bug with theme switch on widget

* Make DonateValues.pctLiquidSplit number type

* Fix slider value not updating

* Reduce z-index of Donate widget header

* Rename remaining border colors to border-prim

* Fix border-prim definition

* Revert Selector

* Update btn widget (#1661)

* Fix donate widget URL

* Revert WidgetConfigurer

* Revert "Make widget example responsive to selected options (#1653)"

This reverts commit 99dd860.

* Replace img widget example with iframe

* Refactor widget iframe snippet to update example on clicking update

* Fix error with widget example not showing

* Add default bg-white to InnerComponent

* Revert changes to pctLiquidSplit type

* Extract iframe into custom IFrame

* Add loader

* Fix widget styling on both mobile and desktop (#1662)

* Update styles on small screens

* Update button styles

* Update text sizes

* Fix mobile styles for config page

* Update Selector style on mobile

* Align config section better on mobile

* Fix max widths for config options section

* Include /donate-widget in `App.tsx` (#1663)

* Donate widget (#1605)

* Add Donate/Widget page

* Rename Steps to StepsPage

* Refactor isHeadingShown

* Update donate widget route to /donate-widget

* Refactor CurrStep

* Add missing space in BtnSec style

* Add query loader scaffold to Widget

* Update BtnSec to use .btn class

* Move DonateWidget to separate /page folder (includes other refactors)

* Move DonateWidget outside the /App component

* Set light mode when opening donation widget

* Add theme setting logic to widget

* Move DonateWidget Content to separate file

* Move Kado modal to Steps & extract CurrentStep

* Refactor isHeadingShown to isFinalized

* Remove redundant WalletSuite Props

* Add widget header section

* Move profile Balances to shared components

* Update Balances to accept direction

* Add Balances to widget

* Extract Balance out of Balances into separate file

* Remove widget header stickiness

* Add footer

* Move WalletSuite to shared components

* Fix title font size in widget

* Add text styling

* Make padded-container have mx-auto on all screen widths

* Add className to Header Logo

* Move Header/Logo to components/APLogo

* Use APLogo in widget footer

* Create separate Balances for widget

* Update Balances styles on widget

* Add alignment styles

* Reduce Steps text size on mobile

* Reduce Steps width inside widget

* Move Donate steps title to just Donate page

* Set z-index of widget header to z-20

* Hide Intercom Chatbot on widget

* Fix App.test

* Refactor CoinBalances

* Remove leftover useBalances

* Remove Balances

* Update the donate widget URL format and route parameter reading logic (#1610)

* Handle null in idParamToNum

* Read endowId from query params

* Move API key check into ApiKeyChecker

* Read endowmentId from route params

* Move Endowment loading into separate loader component

* Add comment for hiding the Intercom chatbot

* Rename DonateWidget/Content to InnerComponent

* Widget page (#1613)

* Add AIF page scaffold

* Add header section of the widget config. page

* Add Views page with routes to AIF

* Add Default widget image section

* Create WidgetUrlConfigForm component

* Comment out id param assignment

* Move WidgetConfigurer to separate folder

* Create Split component

* Add state to WidgetUrlConfigForm

* Rename WidgetUrlConfigForm to WidgetUrlGenerator

* Rename components/Checkbox to CheckboxFormField

* Move Marketplace/../Checkbox to components/* folder

* Add widget URL generator scaffold

* Add 'Available currencies' span

* Rename components/Selector to SelectorFormField

* Extract Selector from SelectorFormField

* Add available currencies selector

* Add useLazyTokensQuery to fetch list of tokens

* Update useApprovedTokens to use useLazyTokensQuery

* Update config sections widths

* Add URL generator logic

* Update widths and alignments

* Update widget-example.png

* Reduce title style font size on sm:

* Add widget URL code section

* Reduce img size

* Reduce url param length

* Move useCopier to hooks/*

* Add Copy URL ability

* Add focus outline on light mode

* Move useCopier back to Copier

* Implement copy/paste this URL section

* Check the boxes on clicking labels

* Center in column on mobile

* Display unfoldAdvancedOptions when \!hideAdvancedOptions

* Add gap-4 on mobile on main screen

* Update alignment on mobile

* Add Reset changes btn

* Move BtnPrim from components/gift to components/*

* Fix donate widget URL

* Revert Copier changes

* Use VarOption where appropriate in Selector

* Use react hook form for URL generation

* Move WidgetUrlGenerator to separate folder

* Show loading ring while approved tokens are loading

* Create DenomSelector

* Add missing FormProvider

* Fix useEndowInfoQuery import path in EndowmentLoader

* Gray out checkbox label on disabled (#1630)

* Configure widget based on URL query params (#1639)

* Extract URL params into separate constants.ts file

* Add as const to URL_PARAMS definition

* Update how boolean URL params are appended

* Add useWidgetParams hook

* Read widget params in DonateWidget

* Update useWidgetParams result

* Hide widget text if set

* Rename Result to UrlParamValues

* Move UrlParamValues to types

* Refactor how UrlParamValues are used

* Move append to bottom of file in WidgetUrlGenerator

* Add UrlParamValues to Steps Props

* Remove hideEndowGauges

* Move main url param fields to ConfigParams type in Steps

* Use widget parameters inside the widget

* Set default gap in widget header

* Fix default widget params

* Fix liquidPercentage append to URL

* Always include fee-paying coin in tokens dropdown when donating

* Remove consloe.log

* Add full iframe for widget url (#1642)

* Rename leftover SelecterFormField references to Selector

* Fix leftover deprecated imports from aws & QueryLoader

* Revert Checkbox to Sidebar/common

* Revert BtnPrim to components/gift

* Remove widgetRoutes

* Remove compnents/BtnPrim

* Remove WalletDetails folder

* Add Sidebar Checkbox back to index

* Make widget example responsive to selected options (#1653)

* Update WidgetConfig example title

* Move url param reading to DonateWidget

* Enable passing of props to DonateWidget

* Refactor DonateWidget to accept default query params

* Refactor how widgetSnippet is generated

* Add className prop to DonateWidget

* Add DonateWidget to WidgetConfigurer instead of image

* Remove widget example img

* Add missing className prop assignment in DonateWidget

* Fix bug in AdvancedOptions unfold logic

* Make DonateWidget responsive to changing params passed from WidgetConfigurer

* Fix DonateWidget width on WidgetConfigurer

* Fix bug with theme switch on widget

* Make DonateValues.pctLiquidSplit number type

* Fix slider value not updating

* Reduce z-index of Donate widget header

* Rename remaining border colors to border-prim

* Fix border-prim definition

* Revert Selector

* Fix donate widget URL

* Revert WidgetConfigurer

* Revert "Make widget example responsive to selected options (#1653)"

This reverts commit 99dd860.

* Replace img widget example with iframe

* Refactor widget iframe snippet to update example on clicking update

* Fix error with widget example not showing

* Add default bg-white to InnerComponent

* Revert changes to pctLiquidSplit type

* Extract iframe into custom IFrame

* Add loader

* keep bundle in App.tsx

Co-authored-by: Nenad Misic <nenad@angelprotocol.io>

* Revert padded-container { xl:mx-auto }

* Make widget example full width on < xl screens

* Update src/components/KadoModal.tsx

Co-authored-by: ap-justin <89639563+ap-justin@users.noreply.github.com>

* Update src/pages/Donate/Content.tsx

Co-authored-by: ap-justin <89639563+ap-justin@users.noreply.github.com>

* Revert changes to App.test.tsx

* Refactor APLogo props

* Remove closing IFrame tag in WidgetConfigurer

* Update src/services/apes/apes.ts

Co-authored-by: ap-justin <89639563+ap-justin@users.noreply.github.com>

* Remove redundant routes and contexts from index.tsx

* Make Split more generic

* Rename name to liqPctField

* Make Split independent of react hook form

* Implement generic Split in Donate Steps

* Add className to Split

* Fix split radtio on widget and config page

* Add token to endowment portion

* Remove isLoading from disabled prop of Split

* Remove Split from Donater

* Remove useApprovedTokens

* Remove min/max range values

* Update Number(e.target.value) to e.target.valueAsNumber

* Make Split depend on react hook form

* Make split type-safe

* Add comment to src/slices/donation/types.ts

Co-authored-by: ap-justin <89639563+ap-justin@users.noreply.github.com>

* Display donater Cancel btn only outside widget

* Create dumbed down widget example

* Extract useCreateWidgetUrl

* Remove unused BtnPrimary

* Fix alignments

* Make widget example a "dumb component" that can perform no actions and hold only placeholder data (#1728)

* Remove react hook form from widget example

* Move WidgetExample to separate folder

* Fix Advanced Options logic

* Fix sizes and layout for WidgetExample

* Remove hover events

* Remove dark: styles

* Remove unused Amount & AmountOptions

* Add "endowment combobox" to widget configuration page + make URL ID param optional (#1746)

* Move Marketplace search logic out of Search into Toolbar

* Move search placeholder to a prop

* Move 'Search' to components/*

* Make isSearching optional

* Add Search to WidgetUrlGenerator

* Fix max width of generator

* Remove AIF page

* Open Widget config on widget-config/:id?

* Update aws endowments endpoint to be easier to use

* Create EndowmentSearch

* Add onFocus func to Search

* Fix type Sort import paths

* Refactor Portion in example adv. opts

* Revert changes to EndowmentsQueryParams

* Update Combobox

* Add back forgotten useLazyProfileQuery

* Revert changes to Marketplace Search

* Remove comment about steps

* Add formValues state to enable manual snippet update

* Revert change to type EndowCardFields

* Hide endow. selector when ID param is passed

* Move getPossessiveForm to helpers/*

* Display actual endow. name in widget example

* Fix endowId check to display Combobox

* Refactor Combobox

* Revert caniuse yarn version

* Make Combobox reusable

* Extract EndowmentCombobox

* Add endowment name when ID param is passed

* Update avail. curr span to label

* Move form state to WidgetConfigurer

* Update code snippet width and text

* Move Combobox content into EndowmentCombobox

* Move EndowmentCombobox to separate folder

* Extract Combobox

* Refactor Combobox

* Extract useWidgetConfigurer

* Refactor widget state

* Fix mention of 'country' to 'endowment' in Combobox

* Move FormValues to State in WidgetConfigurer > types.ts

* Move comment explaining where ID is coming from in Endow Combobox

* Rename WidgetConfigurer/types.ts to schema.ts and State to FormValues

* Extract useLoadDefaultEndowmentName

* Change default height of widget example

* Navigate to widget config from charity admin

* Increase max example height

* Navigate endow admin to endowment's widget embed

* Add loading message on endowment loading

* Add widget link to mobile nav in admin

* Move Widget config page to admin/Charity

* Rename URL ID param from 'id' to 'endowId'

* add padding to top-bottom of main div

---------

Co-authored-by: ap-justin <89639563+ap-justin@users.noreply.github.com>
Co-authored-by: SovereignAndrey <85138450+SovereignAndrey@users.noreply.github.com>
* Remove 'OK' & 'X' btns when uploading images

* Remove 'OK' & 'X' btns when signing changes
…ks based on externally defined objects/lists (#1795)

* Move footer constant types to types.ts

* Rename Footer type Section to LinkGroup

* Make SocialMediaLinks have nullable fields

* Add Links.groups prop

* Make SOCIAL_MEDIA_LINKS into an array

* Add Socials.links prop

* Add linkGroups, socials props to Footer

* Update SocialMediaLink iconType to nullable and link->href

* Extract Link from SocialMediaLink

* Add Header.links prop

* Pass header links to MobileNavOpener

* Make header logo configurable

* Rename APLogo to Logo

* Extract icon size as field in Link[]

* Add hover/active colors to Footer links

* Move LOGO to constants/common
* Remove level field in Documentation > Form > useSubmit

* Add validity check to openIntercom
* Update canius-lite version (#1800)

* HQ Country attribute refactor (#1799)

* HQ Country attribute refactor

* Removed OR operator from hq_country FlatFormValue

* Apply suggestions from code review

Removes unnecessary check for existence of hq_country field, as it is required field for Endowment creation now.

Co-authored-by: ap-justin <89639563+ap-justin@users.noreply.github.com>

* lint clean up

---------

Co-authored-by: SovereignAndrey <85138450+SovereignAndrey@users.noreply.github.com>
Co-authored-by: ap-justin <89639563+ap-justin@users.noreply.github.com>

* HOT FIX: move balances to state query (#1811)

* move balances to state query

* lint warning fixes

* optional active in countries

* fixed logo added (use a png for now)

* switch back to white txt on orange btn due to demands...

* update common logo

---------

Co-authored-by: Nenad Misic <nenad@angelprotocol.io>
Co-authored-by: Juan Paolo Mariano <65009749+jp-mariano@users.noreply.github.com>
Co-authored-by: SovereignAndrey <85138450+SovereignAndrey@users.noreply.github.com>
* modify custom query to query each vault

* combine vaults accBalance and individual vault balance

* add tag invalidation

* HOT FIX: move balances to state query (#1811)

* move balances to state query

* lint warning fixes

---------

Co-authored-by: SovereignAndrey <85138450+SovereignAndrey@users.noreply.github.com>
* Add Dashboard + AIF scaffold

* Add Dashboard layout

* Extract Sidebar

* Add overflow and scroller to sidebar

* Move Logo to components

* Move LogoPlaceholder to Logo

* Refactor Logo

* Add Logo and Switch btn

* Add Logo size

* Remove icon styles from LogoPlaceholder

* Refactor Logo

* Refactor Logo

* Move ProfileContext to contexts/*

* Add ProfileContext to Dashboard

* Pass Dashboard props to Sidebar

* Update Sync icon

* Add endowment name/address section

* Pass link groups to Sidebar

* Add nav link structure to Sidebar

* Move ProfileContext to AIF

* Fix paths in AIF

* Rename links.href to .to

* Rename routes.invest to invest_dashboard

* Add Invest link group

* Extract link group creation

* Add Profile link groups

* Add Profile section

* Add Settings section

* Increase top padding of sidebar header

* Remove max-h & scroller from sidebar

* Rename Dashboard to Container

* Add dark bg to sidebar

* Add className to Sidebar

* Hide Sidebar on mobile

* Update body padding on mobile

* Update grid cols of Container to show on desktop

* Add navigate button on mobile

* Increase sidebar mobile width

* Create NavigationButton

* Move Container to separate folder

* Fix NavigationButton class name

* Rename NavigationButton to MobileNavigationButton

* Add nav btn content change based on URL

* Move MobileNavigationButton to separate folder

* Add AIF fixed min height

* Update dashboard path

* Add Logo

* Add endow. name

* Pass name+logo to sidebar (on mobile too)

* Remove unused icon

* Remove useMemo for linkGroups in AIF

* Refactor MobileSidebar props

* Comment out endow. address

* Add icon.size prop to Link

* Add isSrcLoading prop to Logo

* Load sidebar header from admin resources

* Pass just the endowId to Sidebar

* Move ProfileContext back to pages/Profile and fix errors

* Rename MobileNavigationButton to SidebarToggleButton

* Move Sidebar to components/*

* Fix paths in createLinkGroupsPlaceholder

* Fix loading logic in Header > switch btn and name

* Rename SidebarToggleButton to MobileSidebarButton

* Remove 'aif' from routes

* Fix route in createLinkGroupsPlaceholder

* Show 'Open Menu' instead of throwing error in Mobile sidebar btn

* Move existing Admin pages/components to align with new Sidebar setup (#1804)

* Move Sidebar to /pages/Admin

* Refactor Sidebar to make reusable across desktop/mobile

* Remove endowId prop from Sidebar, read from admin resources

* Update Charity and admin routes to use new linkGroups logic

* Increase size on which Sidebar is in mobile version

* Update Sidebar mobile dialog logic (remove Dialog.Panel from Sidebar)

* Add 'end' prop to Link

* Rearrange LINKS.ts content

* Add grid cols only on md: to admin

* Remove 'divide-x' className from admin layout

* Move Link(Group) types to root Admin/types

* Move LINKS to Admin/constants

* Revert "Move Link(Group) types to root Admin/types"

This reverts commit ba00281.

* Update Review to use new Layout logic

* Fix sidebar min/max heights

* Update Core to use new Layout logic

* Remove min-h for sidebar

* Update widget config endow. name placeholder message

* Remove xl:w-5/6 from WidgetExample

* Create Contributions page

* Fix activeLink finding for mobile sidebar btn

* Close mobile Sidebar on md:

* Reduce sidebar size from sm: to md:

* Memoize createLinkGroups for Charity/index.tsx

* Refactor SidebarOpener

* Return Donations to Dashboard

* Comment out widget config page link

* Update Header shown to AP and Review team

* Remove extra div surrounding endow. name and address

* Extract CharityHeader

* Move Header to folder

* Extract CharityHeader to separate file

* Update colors of header

* Remove light color diff for admin teams

* Rename LOGO to AP_LOGO

* Refactor routes

* Fix issue with useHandleScreenResize in usesidebaropener

* Update activeLink finding in useSidebarOpener to handle subpaths correctly

* Fix activeLink path matching to ignore 'end' paths

* Update Review index title

* Revert 'contributions' to 'donations' in DonationsTable

* Remove commented out route in Charity

* Remove link param in Sidebar.onChange

Co-authored-by: ap-justin <89639563+ap-justin@users.noreply.github.com>

* Make LINKS[key].to type safer

* Refactor activeLink calc

* Refactor Sidebar props

---------

Co-authored-by: ap-justin <89639563+ap-justin@users.noreply.github.com>
* Update testnet contracts

* Add settingsController contract address
* Refactor Code

* Refactor constants

* review fixes
* add container query plugin

* account balances

* center text on mobile

* mobile paddings
* update main logo to new AG svg

* validate amount  on withdraw network change (#1842)

* add max limit to sdg field in schema (#1838)

* Disable Continue unless agreed to TnC (#1841)

* add scroll listener and handle (#1848)

* Add transition to backdrop and Dialog (#1840)

* Add transition to backdrop and Dialog

* Added Panel Wrapper

* Display tokens on hand balance in Profile page (#1851)

* REFACTOR: favorites loading  in wallet dropdown (#1852)

* Admin AP Team - Registrar Config way out of sync with current mainnet contract (#1847)

* update registrar admin config/payloads/forms to reflect current contract state

* additional fields & cleanup

* add in accepted tokens; remove un-used Rebalance items;

* Update src/pages/Admin/Core/Templates/registrar/Config/schema.ts

Co-authored-by: Nenad Misic <nenad@angelprotocol.io>

---------

Co-authored-by: Nenad Misic <nenad@angelprotocol.io>

* Rename `Panel -> Modal`, to align with already existing naming convention (#1853)

* Move Panel out of folder to a Panel.tsx file

* Rename Panel -> Modal

* Refactor props spread in Modal

* Add Modal.Title for consistency

* Align "My Donations" table styles with new Figma designs (#1857)

* Refactor borders

* Use table border instead of outline

* Refactor table styles to include rounded edges

* Fix odd/even coloring on desktop table

* Fix odd/even coloring on mobile table

* Fix coloring for donation details on mobile

* Update mobile layout

* Remove redundant div around mobiletable items

* Remove fixed height h-12 from Disclosure.Button

* Update mobile title to font work

* Truncate tx hash (align with Figma)

* Remove redundant border-b on mobile

* Remove transformResponse from useDonationsQuery

* Fix roundness of mobile rows

* Add load more btn

* Remove bottom roundness from table

* Add hover/active effects to load more btn

* Implement pagionation

* Add limit prop to donations

* Add loading indicator when loading more donations

* Add disabled effect

* Fix showing loading indicator

* Refactor loading indicator

* use charity review for mainnet

---------

Co-authored-by: SovereignAndrey <85138450+SovereignAndrey@users.noreply.github.com>
Co-authored-by: Abbas Ali Lokhandwala <meetabbasali1994@gmail.com>
Co-authored-by: Juan Paolo Mariano <65009749+jp-mariano@users.noreply.github.com>
Co-authored-by: Nenad Misic <nenad@angelprotocol.io>
* update endowment details and remove endow list query

* remove vault rates and vault list query

* remove unused account methods

* Apply suggestions from code review

Co-authored-by: Nenad Misic <nenad@angelprotocol.io>

---------

Co-authored-by: SovereignAndrey <85138450+SovereignAndrey@users.noreply.github.com>
Co-authored-by: Nenad Misic <nenad@angelprotocol.io>
ap-justin and others added 9 commits September 12, 2023 15:12
* add two new fields

* add schema rules

* schema compare to yes no

* reflect type changes

* add in submit

* legal entity field

* default val on fresh doc

* project description field

* hq country label

* text-area
* Web3Auth AWS env vars setup

* Update env.ts

* formatting

---------

Co-authored-by: Andrey <SovereignAndrey>
* update generator payload

* supply paylaod

* use other role

* add more legal entity

* npo at first

* isDirty first

* legal entity back to string

* Remove 'thorough' from label

---------

Co-authored-by: SovereignAndrey <85138450+SovereignAndrey@users.noreply.github.com>
* use custom regex instead

* wallet modal connection order

* include rpc url

* fix lint error

* check only if evm compatible

* revert url change
* admin word/title tweaks

* clean up example widget a bit;

---------

Co-authored-by: Andrey <SovereignAndrey>
@ap-justin ap-justin temporarily deployed to production September 19, 2023 06:42 — with GitHub Actions Inactive
@ap-justin ap-justin changed the title Withdraw beneficiary and source AP-754: Withdraw beneficiary and source Sep 19, 2023
@linear
Copy link

linear bot commented Sep 19, 2023

AP-754 Withdraw: Endowment dropdown list

Similar UI to the Charity widget that we have to allow the endowment to select which charity the widget will send donated funds to.

COS

  • Endowment dropdown list shown on the withdraw tab when sending funds to another Endowment
  • Name is shown in options display with Endowment IDs used as values
  • Searchable list (by name)

@ap-justin ap-justin self-assigned this Sep 20, 2023
@ap-justin ap-justin temporarily deployed to production September 27, 2023 10:31 — with GitHub Actions Inactive
@ap-justin ap-justin temporarily deployed to production September 27, 2023 12:29 — with GitHub Actions Inactive
@ap-justin ap-justin temporarily deployed to production September 27, 2023 12:38 — with GitHub Actions Inactive
@ap-justin ap-justin temporarily deployed to production September 27, 2023 12:42 — with GitHub Actions Inactive
@ap-justin ap-justin changed the title AP-754: Withdraw beneficiary and source AP-754: Withdraw beneficiary dropdown from subgraph Sep 27, 2023
@ap-justin ap-justin added the enhancement New feature or request label Sep 27, 2023
@ap-justin ap-justin marked this pull request as ready for review September 27, 2023 12:48
Copy link
Contributor

@SovereignAndrey SovereignAndrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great! Nice work! :)

@SovereignAndrey SovereignAndrey merged commit 43dd4ed into RC-v1.9 Sep 29, 2023
1 check passed
@SovereignAndrey SovereignAndrey deleted the withdraw-bene branch September 29, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants