Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you add support for English translation? #29

Open
TomerGamerTV opened this issue Jul 7, 2024 · 11 comments
Open

Can you add support for English translation? #29

TomerGamerTV opened this issue Jul 7, 2024 · 11 comments
Assignees

Comments

@TomerGamerTV
Copy link

Could you add support for English translation? I already helped the guy who created the iOS app translate to English so I can help you translate too if you want.

@Viiprogrammer
Copy link
Member

Hmmm, but content is fully rus. All API data and movies, Russian language only. For what? 😱

@TomerGamerTV
Copy link
Author

Hmmm, but content is fully rus. All API data and movies, Russian language only. For what? 😱

Well funny thing is, I understand Russian but I can't read or write it. I don't mind if the contant is in Russian I just want to translate the interface so it will be easier to navigate 👍🏻

@Viiprogrammer
Copy link
Member

Hmmm, but content is fully rus. All API data and movies, Russian language only. For what? 😱

Well funny thing is, I understand Russian but I can't read or write it. I don't mind if the contant is in Russian I just want to translate the interface so it will be easier to navigate 👍🏻

I think will be ok if you can help with code translation, but I not have enough time for this.

@TomerGamerTV
Copy link
Author

TomerGamerTV commented Jul 13, 2024 via email

@Viiprogrammer
Copy link
Member

Can you explain me what needs to be done?

On Sun, 14 Jul 2024 at 1:32 Maksim @.> wrote: Hmmm, but content is fully rus. All API data and movies, Russian language only. For what? 😱 Well funny thing is, I understand Russian but I can't read or write it. I don't mind if the contant is in Russian I just want to translate the interface so it will be easier to navigate 👍🏻 I think will be ok if you can help with code translation, but I not have enough time for this. — Reply to this email directly, view it on GitHub <#29 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKRXGAQWLMCQU4RGE5WCMADZMGTJRAVCNFSM6AAAAABKPO5POOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXGEZDANRXGQ . You are receiving this because you authored the thread.Message ID: @.>

Firstly we need to add i18n for app, extract Russian texts to localization files, because app texts hard-coded directly to templates. I think most big work than just text translation.

I think text extraction is not really hard (because all texts only Russian, easy to find and extract automatically), but we need to replace all texts with placeholders, sometimes with i18n templates.


Because app uses vuetify, and it's contains i18n out of box, we can try by this docs https://v2.vuetifyjs.com/en/features/internationalization/#custom-components

@TomerGamerTV
Copy link
Author

Sorry, but I got no idea how to implement this... 😅
If it will be easier we can technically just create another branch that will only have English text... idk which one will be easier.

@Viiprogrammer
Copy link
Member

Sorry, but I got no idea how to implement this... 😅 If it will be easier we can technically just create another branch that will only have English text... idk which one will be easier.

Ok, No problem, after translate I can check the diff, extract strings and add i18n.

@Viiprogrammer
Copy link
Member

Sorry, but I got no idea how to implement this... 😅 If it will be easier we can technically just create another branch that will only have English text... idk which one will be easier.

Any progress?

@TomerGamerTV
Copy link
Author

Sorry, but I got no idea how to implement this... 😅 If it will be easier we can technically just create another branch that will only have English text... idk which one will be easier.

Any progress?

I'm translating any Russian text I find, the issue is I might accidentally translate unnecessary things so you can either point me to the files that needs to be translated or just revert some translations later 🤷🏻‍♂️

@TomerGamerTV
Copy link
Author

@Viiprogrammer Alright I think I translated everything, I need you to create a new branch called "lord-en" so I can create a pull request and not mess up the main branch 👍🏻

@Viiprogrammer
Copy link
Member

@Viiprogrammer Alright I think I translated everything, I need you to create a new branch called "lord-en" so I can create a pull request and not mess up the main branch 👍🏻

Created https://github.com/AnimeHaze/anilibrix-plus/tree/lord-en

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants