Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Ability to change user language #123

Open
saavran opened this issue Jan 1, 2018 · 13 comments
Open

Feature: Ability to change user language #123

saavran opened this issue Jan 1, 2018 · 13 comments

Comments

@saavran
Copy link
Contributor

saavran commented Jan 1, 2018

Need a drop down menu in popup.html(settings) which will change the user speaking language.

https://github.com/Anna-Assistant/Anna/blob/master/background.js#L183

Has recognition language set to en-us for now.

@gauthamzz
Copy link
Member

Update on this ?

@lalitmee
Copy link
Contributor

lalitmee commented Jan 3, 2018

I was trying to do this. I did some research. I got the design that how we can make it but I didn't find that how to make able multiple language recognition.
This is the link to how it should look like.

@gauthamzz
Copy link
Member

I mean you can keep an array of supported lanagaues and drop down will come . User can select from it. And it will set the variable in background.js .

https://stackoverflow.com/questions/15572595/chrome-extension-access-to-variables-of-a-background-js-from-a-popup-js

@gauthamzz
Copy link
Member

This issue is presently unassisgned

@jat9674
Copy link

jat9674 commented Jan 10, 2018

I would like to solve this issue.

@gauthamzz
Copy link
Member

assigned to you @jat9674

@vikasgola
Copy link
Contributor

@gauthamzz
Don't u think 10 points are very low for this.
I mean 30 points will be good.

@vikasgola
Copy link
Contributor

@gauthamzz
Assign it to me...
I will do it.

@gauthamzz
Copy link
Member

I think this was already solved in the earlier issue by you.

I guess this is a duplicate and already solved. you can take this points as well

@vikasgola
Copy link
Contributor

@gauthamzz
Voices and languages are two different things.
One language can be speak in different style or voices.
And moreover this is releated to speech recognition not to speech synthesis.

The eariler issue that I solved was related to speech synthesis.

@gauthamzz
Copy link
Member

gauthamzz commented Jun 25, 2018

oh yes, you need to make this change https://github.com/Anna-Assistant/Anna/blob/master/background.js#L196

But i think you should use voice and language using the same text box only. i guess 10 is fine then

@gauthamzz gauthamzz reopened this Jun 25, 2018
@vikasgola
Copy link
Contributor

vikasgola commented Jun 25, 2018

@gauthamzz But one language can be speak in many different voices. So it will be better to have another option for languages.

@gauthamzz
Copy link
Member

gauthamzz commented Jun 25, 2018

It will just increase complexity. I like to keep a clean pop up.

We need to keep more settings button and keep few over there , if you would like to do it.

You are free to do what you wish to do. Just make sure the code and the pop up is clean 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants