Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search / filter to make it easier to find tasks #27

Closed
AnotherKamila opened this issue Mar 18, 2018 · 5 comments
Closed

Add search / filter to make it easier to find tasks #27

AnotherKamila opened this issue Mar 18, 2018 · 5 comments

Comments

@AnotherKamila
Copy link
Owner

Add a search field that filters tasks.

Do not try to re-implement taskwarrior's filtering -- just take the text in the search field and send a request to the server every time. It's not worth it to do it locally.

This needs support in the server -- it should accept the search (e.g. as a query string parameter) and add it to its filter.

@evilham
Copy link
Collaborator

evilham commented Mar 24, 2018

I think the server doesn't need changes :). If I recall correctly: when I modified the thing, I made the assumption that this would come :-D.
https://github.com/AnotherKamila/tasksched/blob/master/server.js#L21

@AnotherKamila
Copy link
Owner Author

@evilham yay, you're awesome :D I was too lazy to check when typing that :D great, so it's just a client-side change!

@evilham
Copy link
Collaborator

evilham commented Mar 25, 2018

BTW, a couple things that came to mind:

  • refresh shouldn't lose filters
  • maybe we want to allow for multiple saved (locally) saved filters
  • there's also the thing of synchronisation (of that hypothetical list) across tabs
  • it should be possible to have different filters on different tabs though
  • that would mean that any custom filters should be visible on the UI
  • maybe it'd be a time to show the name of the current context if one is active?

Basically, it should be easy to know what one is seeing :-D
What do you think? :)

@AnotherKamila
Copy link
Owner Author

AnotherKamila commented Mar 25, 2018 via email

@evilham
Copy link
Collaborator

evilham commented Feb 1, 2019

@AnotherKamila ping :-D

@evilham evilham pinned this issue Feb 1, 2019
@evilham evilham closed this as completed in c0fe483 Mar 5, 2019
@evilham evilham unpinned this issue Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants