Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tools.py #135

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Update tools.py #135

merged 1 commit into from
Nov 18, 2021

Conversation

Anselmoo
Copy link
Owner

No description provided.

@Anselmoo Anselmoo added the documentation Improvements or additions to documentation label Nov 18, 2021
@Anselmoo Anselmoo self-assigned this Nov 18, 2021
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 18, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 2.34 ⭐ 2.34 ⭐ 0.00
Method Length 49.41 ⭐ 49.41 ⭐ 0.00
Working memory 6.72 🙂 6.72 🙂 0.00
Quality 79.49% 79.49% 0.00%
Other metrics Before After Change
Lines 497 498 1
Changed files Quality Before Quality After Quality Change
spectrafit/tools.py 79.49% ⭐ 79.49% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
spectrafit/tools.py PostProcessing.make_residual_fit 4 ⭐ 99 🙂 10 😞 65.16% 🙂 Extract out complex expressions
spectrafit/tools.py PostProcessing.rename_columns 3 ⭐ 51 ⭐ 11 😞 71.44% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #135 (626e469) into main (73aad66) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files          10       10           
  Lines        1230     1230           
=======================================
  Hits         1217     1217           
  Misses         13       13           
Impacted Files Coverage Δ
spectrafit/tools.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73aad66...626e469. Read the comment docs.

@Anselmoo Anselmoo merged commit 5dcecfa into main Nov 18, 2021
@Anselmoo Anselmoo deleted the develope branch November 18, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant