Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis config #40

Merged
merged 17 commits into from
Sep 5, 2016
Merged

Travis config #40

merged 17 commits into from
Sep 5, 2016

Conversation

Antar1011
Copy link
Owner

No description provided.

@Antar1011
Copy link
Owner Author

So it's looking like there are issues with file-persistence, possibly having to do with the tests being run out of order.

@Antar1011
Copy link
Owner Author

No, it actually looks like py-mini-racer is failing to build...

@Antar1011
Copy link
Owner Author

Okay, what the Walter, Walter?

python 3.4.3 (default, Oct 14 2015, 20:28:29) 
[GCC 4.8.4] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from collections import namedtuple
>>> Blah_ = namedtuple('Blah', ['x', 'z'])
>>> class Blah(Blah_):
...   pass
... 
>>> Blah(3, 4)
Blah(x=3, z=4)
>>> Blah(3, 4)._asdict()
{}

@Antar1011
Copy link
Owner Author

It's a known issue: https://bugs.python.org/issue24931

Guess I should get the attributes a different way (or not have the DTOs use namedtuples).

@Antar1011
Copy link
Owner Author

checks passed

@Antar1011
Copy link
Owner Author

So I'm satisfied (for now) with this only working on 3.5 and 2.7, but before closing the PR I'd like to get coveralls set up as well.

@coveralls
Copy link

coveralls commented Sep 5, 2016

Coverage Status

Changes Unknown when pulling cbe58ce on travis-integration into * on master*.

@coveralls
Copy link

coveralls commented Sep 5, 2016

Coverage Status

Changes Unknown when pulling 28cad02 on travis-integration into * on master*.

@Antar1011
Copy link
Owner Author

All right! Travis is working, coveralls is working! I'm satisfied!

Resolves #19

@Antar1011 Antar1011 merged commit ebc1262 into master Sep 5, 2016
@Antar1011 Antar1011 deleted the travis-integration branch September 5, 2016 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants