Integration test #61
Merged
Integration test #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently fails because the CASE clause is too large for SQLAlchemy (boo!). See: http://stackoverflow.com/questions/7106016/too-many-sql-variables-error-in-django-witih-sqlite3
|
This build will fail, but it's because this PR has revealed a bug, not because it's introduced one, so I'm merging it, even as I work on the solution. |
|
To be clear, I don't love that this test is randomly generated. But I did it with the LogProcessor tests as well, so if I'm going to make an issue of it here, I should fix it there too. Maybe I'll make a "tech debt" ticket? |
Closed
|
Weirdly, the error I reported in #62 is not the error that gets thrown on Travis. Wonder if the difference is due to different versions of SQLAlchemy..? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In writing this test, I've discovered a major bug owing to how SQLAlchemy compiles queries. Basically, the current scheme will not work for a full species-lookup. It also won't handle bulk inserts.
See: http://stackoverflow.com/questions/7106016/too-many-sql-variables-error-in-django-witih-sqlite3
The bulk inserts issue can be resolved by doing them the correct way (that is, using the
valuesargument inexecute()rather than the.values()function inInsert).The solution to the species-lookup issue appears to be making a temporary table.