Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unitcount limit for time series generation ANT-1248 #1960

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Remove unitcount limit for time series generation ANT-1248 #1960

merged 3 commits into from
Feb 26, 2024

Conversation

payetvin
Copy link
Contributor

No description provided.

@payetvin payetvin added bug Something isn't working code quality labels Feb 23, 2024
@payetvin payetvin self-assigned this Feb 23, 2024
flomnes
flomnes requested changes Feb 23, 2024
View reviewed changes
Copy link
Member

@flomnes flomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use the 366 literal, use DAYS_PER_YEAR instead.

src/solver/ts-generator/thermal.cpp Outdated Show resolved Hide resolved
src/solver/ts-generator/thermal.cpp Outdated Show resolved Hide resolved
@flomnes flomnes merged commit 4ba630c into develop Feb 26, 2024
4 of 5 checks passed
@flomnes flomnes deleted the fix/ts-unitcount branch February 26, 2024 08:27
@payetvin payetvin mentioned this pull request Mar 18, 2024
Merged
payetvin added a commit that referenced this pull request Mar 18, 2024
@payetvin
Remove unitcount limit for time series generation ANT-1248 (#1960)
9319b58
@payetvin payetvin mentioned this pull request Mar 18, 2024
Merged
payetvin added a commit that referenced this pull request Mar 18, 2024
@payetvin
cherry pick PR #1960
2f820ab
flomnes added a commit that referenced this pull request Mar 26, 2024
@payetvin @flomnes
8.6.6 (#1999)
69bea81 
Backport some bugfixes
#1969
#1960
#1982

---------

Co-authored-by: Florian OMNES <florian.omnes@rte-france.com>
flomnes added a commit that referenced this pull request Mar 26, 2024
@payetvin @flomnes
8.8.4 (#1998)
8e84e32 
Backport some bugfixes
 #1969
#1960
 #1982

---------

Co-authored-by: Florian OMNES <florian.omnes@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomnes flomnes flomnes approved these changes

Assignees

@payetvin payetvin

Labels
bug Something isn't working code quality size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@payetvin @flomnes