Release 3.0 pull request #36

Merged
merged 3 commits into from Mar 21, 2012

Conversation

Projects
None yet
4 participants
@scottnickel
Contributor

scottnickel commented Mar 13, 2012

Hi Matt.

Please pull the changes for issue #26 and issue #27.

They are tagged under 20120313_Issue26_Issue27 or you can just get current from my fork.

I will not push anything further until I hear from you.

Let me know.

Thanks,

Scott

scottnickel added some commits Mar 13, 2012

Issue 26 - ViewBag
Issue 27 - Streamlining the ITemplateService API
@Antaris

This comment has been minimized.

Show comment
Hide comment
@Antaris

Antaris Mar 13, 2012

Looking good, can you create a Pull request, and I can see about merging that into the core release-3.0 branch :-)

Looking good, can you create a Pull request, and I can see about merging that into the core release-3.0 branch :-)

This comment has been minimized.

Show comment
Hide comment
@scottnickel

scottnickel Mar 13, 2012

Owner
Owner

scottnickel replied Mar 13, 2012

This comment has been minimized.

Show comment
Hide comment
@scottnickel

scottnickel Mar 13, 2012

Owner
Owner

scottnickel replied Mar 13, 2012

This comment has been minimized.

Show comment
Hide comment
@Antaris

Antaris Mar 13, 2012

Think we'll leave it as is for now. The majority of users don't actually use a TemplateService directly, rather they use the static Razor type instead. Rather try and minimise impact. After I've merged the pull request, I'll push it out as v3.0.9beta and see what happens basically!

Think we'll leave it as is for now. The majority of users don't actually use a TemplateService directly, rather they use the static Razor type instead. Rather try and minimise impact. After I've merged the pull request, I'll push it out as v3.0.9beta and see what happens basically!

Antaris pushed a commit that referenced this pull request Mar 21, 2012

@Antaris Antaris merged commit 1a3f70f into Antaris:release-3.0 Mar 21, 2012

@Jeff-Lewis

This comment has been minimized.

Show comment
Hide comment
@Jeff-Lewis

Jeff-Lewis May 31, 2012

It appears 2 Unit Tests are failing from this commit.

Issue21_SubclassModelShouldBeSupportedInLayout : Failed
System.NullReferenceException : Object reference not set to an instance of an object.
at CompiledRazorTemplates.Dynamic.dbdfedadfffee.Execute()
at RazorEngine.Templating.TemplateBase.RazorEngine.Templating.ITemplate.Run(ExecuteContext context) in TemplateBase.cs: line 120
at RazorEngine.Templating.TemplateBase.RazorEngine.Templating.ITemplate.Run(ExecuteContext context) in TemplateBase.cs: line 133
at RazorEngine.Templating.TemplateService.Run(ITemplate template, DynamicViewBag viewBag) in TemplateService.cs: line 559
at RazorEngine.Templating.TemplateService.Parse(String razorTemplate, Object model, DynamicViewBag viewBag, String cacheName) in TemplateService.cs: line 424
at RazorEngine.Tests.TestTypes.Issues.Release_3_0_TestFixture.Issue21_SubclassModelShouldBeSupportedInLayout() in Release_3_0_TestFixture.cs: line 232

Issue6_ModelShouldBePassedToLayout : Failed
System.NullReferenceException : Object reference not set to an instance of an object.
at System.Object.GetType()
at RazorEngine.Compilation.RazorDynamicObject.TryGetMember(GetMemberBinder binder, ref Object result) in RazorDynamicObject.cs: line 36
at CallSite.Target(Closure, CallSite, Object)
at System.Dynamic.UpdateDelegates.UpdateAndExecute1<T0,TRet>(CallSite site, T0 arg0)
at CompiledRazorTemplates.Dynamic.eebeaaacbc.Execute()
at RazorEngine.Templating.TemplateBase.RazorEngine.Templating.ITemplate.Run(ExecuteContext context) in TemplateBase.cs: line 120
at RazorEngine.Templating.TemplateBase.RazorEngine.Templating.ITemplate.Run(ExecuteContext context) in TemplateBase.cs: line 133
at RazorEngine.Templating.TemplateService.Run(ITemplate template, DynamicViewBag viewBag) in TemplateService.cs: line 559
at RazorEngine.Templating.TemplateService.Parse(String razorTemplate, Object model, DynamicViewBag viewBag, String cacheName) in TemplateService.cs: line 424
at RazorEngine.Tests.TestTypes.Issues.Release_3_0_TestFixture.Issue6_ModelShouldBePassedToLayout() in Release_3_0_TestFixture.cs: line 42

It appears 2 Unit Tests are failing from this commit.

Issue21_SubclassModelShouldBeSupportedInLayout : Failed
System.NullReferenceException : Object reference not set to an instance of an object.
at CompiledRazorTemplates.Dynamic.dbdfedadfffee.Execute()
at RazorEngine.Templating.TemplateBase.RazorEngine.Templating.ITemplate.Run(ExecuteContext context) in TemplateBase.cs: line 120
at RazorEngine.Templating.TemplateBase.RazorEngine.Templating.ITemplate.Run(ExecuteContext context) in TemplateBase.cs: line 133
at RazorEngine.Templating.TemplateService.Run(ITemplate template, DynamicViewBag viewBag) in TemplateService.cs: line 559
at RazorEngine.Templating.TemplateService.Parse(String razorTemplate, Object model, DynamicViewBag viewBag, String cacheName) in TemplateService.cs: line 424
at RazorEngine.Tests.TestTypes.Issues.Release_3_0_TestFixture.Issue21_SubclassModelShouldBeSupportedInLayout() in Release_3_0_TestFixture.cs: line 232

Issue6_ModelShouldBePassedToLayout : Failed
System.NullReferenceException : Object reference not set to an instance of an object.
at System.Object.GetType()
at RazorEngine.Compilation.RazorDynamicObject.TryGetMember(GetMemberBinder binder, ref Object result) in RazorDynamicObject.cs: line 36
at CallSite.Target(Closure, CallSite, Object)
at System.Dynamic.UpdateDelegates.UpdateAndExecute1<T0,TRet>(CallSite site, T0 arg0)
at CompiledRazorTemplates.Dynamic.eebeaaacbc.Execute()
at RazorEngine.Templating.TemplateBase.RazorEngine.Templating.ITemplate.Run(ExecuteContext context) in TemplateBase.cs: line 120
at RazorEngine.Templating.TemplateBase.RazorEngine.Templating.ITemplate.Run(ExecuteContext context) in TemplateBase.cs: line 133
at RazorEngine.Templating.TemplateService.Run(ITemplate template, DynamicViewBag viewBag) in TemplateService.cs: line 559
at RazorEngine.Templating.TemplateService.Parse(String razorTemplate, Object model, DynamicViewBag viewBag, String cacheName) in TemplateService.cs: line 424
at RazorEngine.Tests.TestTypes.Issues.Release_3_0_TestFixture.Issue6_ModelShouldBePassedToLayout() in Release_3_0_TestFixture.cs: line 42

This comment has been minimized.

Show comment
Hide comment
@scottnickel

scottnickel May 31, 2012

Contributor

Matt,

I was not involved in this change...but I can look into it.

Let me know if someone else is already looking at it.

Thanks,

Scott

Contributor

scottnickel replied May 31, 2012

Matt,

I was not involved in this change...but I can look into it.

Let me know if someone else is already looking at it.

Thanks,

Scott

This comment has been minimized.

Show comment
Hide comment
@AlexBar

AlexBar Nov 11, 2012

Contributor

I've fixed that issue: #74

Contributor

AlexBar replied Nov 11, 2012

I've fixed that issue: #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment