New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Obsolete tests to use RazorEngineService #478

Merged

matthid merged 2 commits into Antaris:master from conniey:fixObsoleteTests

Jul 1, 2017

Contributor

conniey commented Jun 29, 2017 •

edited

Loading

This updates the tests that were marked obsolete to use RazorEngineService instead of the TemplateService.
This fixes the warning in CompilerServiceBase.cs about _disposed being unused by using it in part of the IDisposable pattern.

Part of changes to support #414

conniey added 2 commits

June 28, 2017 18:34


          Replacing TemplateService with RazorEngineService.Create()

faa58fe


          Fix variable _disposed is unused warning by implementing its Dispose …

3a1eea0

…pattern

Collaborator

matthid commented Jul 1, 2017

Thank you. I guess it's about time to update these tests. Looks good!

matthid merged commit a2a17c5 into Antaris:master

conniey deleted the fixObsoleteTests branch

July 3, 2017 17:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet