[3.0] fix is_explicit_nested in abi generator gen.hpp #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #15
is_explicit_nested
determines if a type is nested. It currently just counts the number of<
s and returnstrue
if the number is greater than1
. This causes problems for types containingstd::vector<char>
, asstd::vector<char>
actually converted tobytes
and should not be considered as a vector. For example,is_explicit_nested
returnstrue
forstd::map<uint64_t,std::vector<char>>
as a nested container and it leads to an ABI ofThis breaks existing users.
Change to determine nestedness semantically.
Change Description
API Changes
Documentation Additions