[3.2] Report transaction failed if trx was exhausted in non-producing mode #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we restart a speculative block to retry it immediately, instead of waiting to receive a new block
heifner
requested changes
Jun 20, 2023
heifner
reviewed
Jun 21, 2023
heifner
approved these changes
Jun 21, 2023
greg7mdp
changed the title
linh2931
reviewed
Jun 21, 2023
| exhausted = pr.block_exhausted; | ||
|
|
||
| if ( !in_producing_mode() && pr.trx_exhausted ) | ||
| exhausted = true; // report transaction exhausted if trx was exhausted in non-producing mode (so we will restart |
linh2931
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we restart a speculative block to retry it immediately, instead of waiting to receive a new block.
Resolves #1247.