[3.2] remove old, unused, and currently broken alternate k1 ECC impls #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point long long ago it might have been possible to use alternate implementations of k1 ECC math by switching the
ECC_IMPLconfig toopensslormixed. My hunch is no one has ever made use of these in the EOSIO/Leap timeframe, and neither of those compile now. Maybe we could consider fixing them butec_recover.cppalready usessecp256k1directly making usage of that library a requirement regardless.I think it's best to go ahead and just remove what might as well be old cruft.