-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.2] Refactor producer_plugin to consolidate controller push_transaction calls #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
changed the title
Refactor producer_plugin to consolidate controller push_transaction calls
[3.2] Refactor producer_plugin to consolidate controller push_transaction calls
Aug 19, 2022
heifner
commented
Aug 22, 2022
heifner
commented
Aug 22, 2022
…or invalid signature transactions.
…leap into prod-plugin-push-trx
…le unapplied_transaction_queue handling. Also use unapplied_transaction_queue iterator to avoid trying the same incoming transaction twice in start block.
heifner
commented
Aug 25, 2022
heifner
commented
Aug 25, 2022
heifner
commented
Aug 25, 2022
heifner
commented
Aug 25, 2022
heifner
commented
Aug 25, 2022
heifner
commented
Aug 25, 2022
heifner
commented
Aug 26, 2022
heifner
commented
Aug 26, 2022
heifner
commented
Aug 26, 2022
heifner
commented
Aug 26, 2022
oschwaldp-oci
approved these changes
Aug 26, 2022
greg7mdp
added a commit
that referenced
this pull request
Nov 8, 2023
heifner
added a commit
that referenced
this pull request
Apr 29, 2024
IF: Add deep-mind ACCEPTED_BLOCK_V2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
producer_plugin
had duplicate code around calling chaincontroller
push_transaction
which resulted in slight differences in handling of error conditions; particularly around logging of failures. This PR refactors the calling of controllerpush_transaction
into a commonpush_transaction
call so that all instances of handling incoming transactions are handled the same way. Now all transactions are logged regardless of the stage of execution. Also ordering of log messages are now consistent withtransaction
logged beforetransaction_success_tracing
/transaction_failure_tracing
which is logged beforetransaction_trace_success
/transaction_trace_failure
.Includes a slight change to log output format of eosnetworkfoundation/mandel#733, new example:
Includes a fix for
channels::transaction_ack
not always being signaled for expired or transactions with invalid signatures.Includes a change to set
disable-api-persisted-trx=true
when running inHEAD
mode as transaction side-effects are undone anyway when inHEAD
mode so no need to ever speculatively execute them.Resolves eosnetworkfoundation/mandel#297