Merge SHiP stability fixes & log splitting & memory usage improvements #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opeio/leap into huangminghuang/ship-memory
# Conflicts: # libraries/state_history/include/eosio/state_history/log.hpp # plugins/state_history_plugin/include/eosio/state_history_plugin/session.hpp # plugins/state_history_plugin/tests/session_test.cpp
huangminghuang
added a commit
that referenced
this pull request
Feb 10, 2023
…ship-log # Conflicts: # libraries/chain/include/eosio/chain/log_catalog.hpp # libraries/chain/include/eosio/chain/log_data_base.hpp # libraries/chain/include/eosio/chain/log_index.hpp
huangminghuang
changed the base branch from
main
to
huangminghuang/block_log
linh2931
approved these changes
Feb 13, 2023
ScottBailey
reviewed
Feb 27, 2023
greg7mdp
reviewed
Mar 1, 2023
ScottBailey
reviewed
Mar 2, 2023
ScottBailey
reviewed
Mar 2, 2023
plugins/state_history_plugin/include/eosio/state_history_plugin/session.hpp
Outdated
Show resolved
Hide resolved
ScottBailey
suggested changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges #638 on top of #577 & #599. Also includes some additional misc. cleanup.
Addresses the double memory used when starting from a snapshot via merge of #577.
This PR backports EOSIO/eos#9277 and EOSIO/eos#9821 to support supports the trace and chain state log spliting in state history plugin.
Some new options for state history plugin are added:
state-history-stride: split the state history log files when the block number is the multiple of the stride. When the stride is reached, the current history log and index will be renamed '*-history--.log/index' and a new current history log and index will be created with the most recent blocks. All files following this format will be used to construct an extended history log.max-retained-history-files: the maximum number of state history log file groups to retain so that the blocks in those files can be queried. When the number is reached, the oldest log files would be moved to archive dir or deleted if the archive dir is empty. The retained log files should not be manipulated by users.state-history-retained-dir: the location of the state history retained directory (absolute path or relative to state-history dir).state-history-archive-dir: the location of the state history archive directory (absolute path or relative to state-history dir). If the value is empty string, log files beyond the retained limit will be deleted. All files in the archive directory are completely under user's control, i.e. they won't be accessed by nodeos anymore.Verified this branch also fixes #592, #203