Skip to content
This repository has been archived by the owner on Oct 12, 2021. It is now read-only.

Add CSS styling for Firefox #17

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Conversation

Garulf
Copy link
Contributor

@Garulf Garulf commented Jul 15, 2021

Tested on Chrome, iOS, Firefox.... No issues.

Attaches styling to Firefox input thumb.

@AnthonMS AnthonMS marked this pull request as ready for review July 15, 2021 16:20
@AnthonMS AnthonMS merged commit 2f7185d into AnthonMS:master Jul 15, 2021
@AnthonMS
Copy link
Owner

Looks good, thank you! I will update the guy with the issue if you haven't done it already.

@Garulf
Copy link
Contributor Author

Garulf commented Jul 15, 2021

Go for it, he may have to adjust his styling as firefox is a little wacky on thumb dimensions.

@AnthonMS AnthonMS mentioned this pull request Jul 15, 2021
@AnthonMS
Copy link
Owner

Okay.

To go off topic, after I saw your repo with ha-commander some time ago, I started looking into making an updated version of that, but for Flow Launcher. I had a ton of problems with it and found a ton of bugs in writing plugins in any other language than C#. I can see you have made one for MDI in python, is it interactable or simply showing results in the queries?
I couldn't get any feedback from the user to work and call a function, but I talked a lot with the devs, and they should have fixed them, I just lost hope after a couple weeks finding new bugs every time they made a hot-fix.

@Garulf
Copy link
Contributor Author

Garulf commented Jul 15, 2021

I was actually going to update that myself it's poorly written and very outdated. But Wox is basically dead and I just found Flow launcher which seems promising but python plugins were broken.

I found an obscure PR were someone had linked a working beta binary that fixes the issues though: Here. Download the .exe binary on that page.

The MDI plugin right now shows a preview of the icon, and copy's the name into your clipboard. Very handy for customizing home assistant icons. Just make sure you have pywin32 and requests packages on your system.

@AnthonMS
Copy link
Owner

Okay, I don't think I will be creating the HA plugin then. Plus I have found HA Desktop app, which looks promising. Just haven't had the time to try it out yet.

But I will try this out, thank you.

@Garulf
Copy link
Contributor Author

Garulf commented Jul 16, 2021

I'm going to start on a rewrite this weekend now that I've ironed out the bugs in Flow launcher, You're more then welcome to contribute of course!

Have you add any luck with getting Flow launcher to work?

@AnthonMS
Copy link
Owner

AnthonMS commented Jul 16, 2021

I haven't tried in a couple weeks. Last time I tried there where still 2-3 different bugs with the RPC callback, so no matter what I did I couldn't call custom functions and I couldn't call flowlauncher API functions to change query etc.

But the devs responded saying these bugs should have also been fixed, but just lost my interest after 2-3 weeks of non-stop bug hunting and it didn't seem like we where getting closer to getting it to work. Every time they fixed a bug, two new bugs appeared..

But if you are saying they have fixed them, so we can at least make the plugins interactable, then I might just take a look at it again.

But to be honest, I have enough side projects, and I think I will give this slider card some more love when I have time. There are major changes that I would love to implement to make the code more clean, but also visually like text inside the slider and stuff like that.

@Garulf
Copy link
Contributor Author

Garulf commented Jul 16, 2021

I haven't tried in a couple weeks. Last time I tried there where still 2-3 different bugs with the RPC callback, so no matter what I did I couldn't call custom functions and I couldn't call flowlauncher API functions to change query etc.

Yeah had the same frustrations, plug-ins are in a very early state unless you write one in C#.

But the devs responded saying these bugs should have also been fixed, but just lost my interest after 2-3 weeks of non-stop bug hunting and it didn't seem like we where getting closer to getting it to work. Every time they fixed a bug, two new bugs appeared..

Once I updated to that release candidate build I haven't had any further bugs.

But to be honest, I have enough side projects, and I think I will give this slider card some more love when I have time. There are major changes that I would love to implement to make the code more clean, but also visually like text inside the slider and stuff like that.

Well I can say the code is very readable, which helped a lot with my PRs. I can't wait to see the changes. Text inside the slider will make it feel more complete.

I've been mulling over the best way to add that since I came across your repo.

@AnthonMS
Copy link
Owner

I might give it a go again sometime then.

Well I'm glad thar it's already readable. And yeah, I have already tried, back when I made it first, but just couldn't get it styled correctly. But I will try some different stuff again soon, because it would make it more complete.

@Garulf
Copy link
Contributor Author

Garulf commented Jul 20, 2021

Got HA-Commander in a much better state if you'd like to take it for a spin. Just requires requests package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants