Refactoring of clocksi_interactive_coord #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new state wait_for_start_transaction - no work done in init, instead all blocking is done when wait_for_start_transaction receives a start_tx message - the change above allows us to remove the 100 instances of clocksi_interactive_coord_worker_sup and directly start the clocksi_interactive_coord under the clocksi_interactive_coord_sup - added a new function prepare_done that is always executed befor beginning the commit phase - removed redundant match-expressions - removed StayAlive (which was always set to false in production)
bieniusa
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit phase
Old state graph:
graph_old.pdf
After this PR:
graph_new.pdf