"Borderless Window" setting only makes game fullscreen

[joshuaptfan]

Platform: Windows

Build: 129.1

Issue: In graphics settings, both the "Fullscreen" and "Borderless Window" settings make the game fullscreen, when enabled individually or together. "Borderless Window" works correctly in build 126.3.

Steps to reproduce: Disable "Fullscreen" and enable "Borderless Window". Press the Windows key and observe that the screen blinks which indicates that Mindustry was actually fullscreen.

Link(s) to mod(s) used: None

Save file: Irrelevant

If you remove the line above without reading it properly and understanding what it means, I will reap your soul. Even if you're playing on someone's server, you can still save the game to a slot.

(Crash) logs: No crash

---

Place an X (no spaces) between the brackets to confirm that you have read the line below.

• I have updated to the latest release (https://github.com/Anuken/Mindustry/releases) to make sure my issue has not been fixed.
• I have searched the closed and open issues to make sure that this problem has not already been reported.

[Anuken]

This is a change of behavior in SDL, possibly a bug. I maximize the window after enabling borderless windows, but apparently that just enables fullscreen now.

Without the maximization, it just looks like this:

Borderless windows still works fine on Ubuntu, however.

[Anuken]

Appears to fix #4360, #2110 as well.

[joshuaptfan]

Testing this build, it results in a different bug. "Borderless Window" no longer expands the window to cover the taskbar. (The game window used to cover the whole screen like "borderless fullscreen" in other games.)

[Anuken]

"Borderless Window" no longer expands the window to cover the taskbar.

It was not supposed to do that, and never did in my version. Borderless windowed is not supposed to be borderless fullscreen.

[Anuken]

If borderless fullscreen is what people need, then the setting should be named accordingly on Windows. On Linux (and possibly Mac), that setting does not (cannot?) make the window fullscreen.