Latisimus calibration #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the missing calibration for the new latissimus dorsi elements. It also ensure all latissimus dorsi elements are calibrated at the same posture.
This ensure that the only real muscle are calibrated in armcal0. This is purely a cleanup, since calibration has no effect on 'AnyGeneralMuscle'
melund
commented
May 18, 2022
menzejo
approved these changes
May 19, 2022
|
@menzejo, Thanks a ton for this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes missing calibration for the new latissimus dorsi elements introduced in AMMR 2.4.
This fix also ensures all latissimus dorsi elements are calibrated in the same arm posture.
Fixes #674 #675
Thanks to @menzejo for spotting this.