Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove links to old ammr-doc URL #873

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Remove links to old ammr-doc URL #873

merged 2 commits into from
Nov 6, 2023

Conversation

melund
Copy link
Member

@melund melund commented Nov 6, 2023

No description provided.

@melund melund requested a review from bkje14 November 6, 2023 12:05
@melund
Copy link
Member Author

melund commented Nov 6, 2023 •
edited
Loading

@bkje14, @divyaksh-chander, I was just adding you guys reviewers to point out the fact that the ammr documentation has moved:

https://anyscript.org/ammr-doc -> https://anyscript.org/ammr

Redirects have been setup, so old links still work. But This PR helps eradicate some of them.

bkje14
bkje14 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@bkje14 bkje14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change in URI, I like that 👍🏼
The link also works for me :)

divyaksh-chander
divyaksh-chander approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@divyaksh-chander divyaksh-chander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, but we should mention this to everyone in the company, especially, sales. I just checked that previous links using ammr-doc are redirected to the new page. That is nice!

@melund melund merged commit 5769e48 into master Nov 6, 2023
23 checks passed
@melund melund deleted the fix-docs-links branch November 6, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkje14 bkje14 bkje14 approved these changes

@divyaksh-chander divyaksh-chander divyaksh-chander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@melund @bkje14 @divyaksh-chander