Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Selected outputs for cervical spine #876

Merged
merged 30 commits into from
Nov 13, 2023
Merged

Conversation

divyaksh-chander
Copy link
Contributor

@divyaksh-chander divyaksh-chander commented Nov 9, 2023

Change orientation to measure compression and shear force at joints.
The trunk joint reaction force (C7T1 to C0C1) are now expressed in new reference nodes that are aligned with the vertebral body. These new reference nodes are created inside the lumbar joint nodes of the proximal lumbar segment.

  • The selected outputs for trunk JRF are updated to use the new oriented rot nodes.
  • Some documentation is added in the selected outputs file describing the interpretation of the JRF.
  • Names of the selected outputs are updated from to include compression and shear force. This will break existing models and will bring this change to the attention of the users.
  • Users can enable the previous outputs with a compatibility switch #define BM_COMPATIBILITY_24_TRUNK_SELECTED_OUTPUTS_JRF ON
  • Names of cervical JRF in selected outputs are changed from C(x)C(x-1) to C(x-1)C(x) to be consistent with the lumbar outputs.
  • Change log has been updated

divyaksh-chander and others added 26 commits November 2, 2023 15:29
…ce to new nodes aligned with the vertebral body.
…the reference nodes aligned with the vertebral body
…te ARel of RotNode in jntnodes to use the right and left points
…orce to new nodes aligned with the vertebral body.
…o the reference nodes aligned with the vertebral body
…orce to new nodes aligned with the vertebral body.
…o the reference nodes aligned with the T1 vertebral body
@melund
Copy link
Member

melund commented Nov 10, 2023

@divyaksh-chander, I have fixed the reason documentation fails to build on the master branch. I just pushing the "Update branch" button here on GitHub. That will merge the master branch in, and then test should pass.

@divyaksh-chander divyaksh-chander marked this pull request as ready for review November 13, 2023 10:02
@melund melund merged commit 7b17805 into master Nov 13, 2023
23 checks passed
@melund melund deleted the SpineJRF-SelectedOutputs branch November 13, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants