fix(bvh-protocol): Update foot markers #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyaksh-chander
force-pushed
the
xsens-protocol-foot
branch
from
43eb235
to
641145f
Compare
melund
requested changes
Apr 6, 2024
Apply suggestion Co-authored-by: Morten Enemark Lund <mel@anybodytech.com> Signed-off-by: divyaksh-chander <102362310+divyaksh-chander@users.noreply.github.com>
melund
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to the ankle joint in TLEM 2.2 model resulted in a different calculation of the ankle plantarflexion angle in bvh models. This PR updates the feet marker position in the Xsens protocol to counter the introduced offset. The markers have been moved closer to the foot by 1.5 cm (Y axis).
Changelog entry is added as well.