Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AnyMoCap): Ensure force plate visualization can not have zero height #941

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

melund
Copy link
Member

@melund melund commented Apr 9, 2024

No description provided.

@github-actions github-actions bot added the fix label Apr 9, 2024
@melund melund requested a review from mdabt April 9, 2024 07:21
Copy link
Member Author

@melund melund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdabt, The AnySurf 'assert' failures I found the debug version yesterday was due to a box representing the force plate scaled to have zero height. This fix in AMMR ensures this can't happen: Even when the C3D file specifies the plate thinkness as zero.

Copy link
Contributor

@mdabt mdabt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good fix to this problem.

@melund melund merged commit fbd22a8 into master Apr 10, 2024
26 checks passed
@melund melund deleted the fix-plate-height branch April 10, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants