Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow getting contract types for non-checksummed addresses #56

Closed
wants to merge 2 commits into from

Conversation

antazoey
Copy link
Member

What I did

Was unable to get contract types when address was not checksummed and I got confused.

How I did it

Check if address type (which checks if checksum) and if not, convert it.

How to verify it

address.lower() <-- use this as a value

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey
Copy link
Member Author

#58 oops

@antazoey antazoey closed this Nov 17, 2022
@antazoey antazoey deleted the fix/jules/checksumaddr branch November 17, 2022 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants