Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updated ape core version #13

Merged
merged 2 commits into from
Jul 27, 2022
Merged

chore: updated ape core version #13

merged 2 commits into from
Jul 27, 2022

Conversation

NotPeopling2day
Copy link
Contributor

update core version

antazoey
antazoey approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
One other optional thing: make the contributing install instructions put quotes around dev

pip instal -e .'[dev]'

instead of pip instal -e .[dev] since that does not work on macs

@NotPeopling2day NotPeopling2day merged commit 4606d84 into ApeWorX:main Jul 27, 2022
@NotPeopling2day NotPeopling2day deleted the chore/ape-version branch July 27, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antazoey antazoey antazoey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NotPeopling2day @antazoey