fix: singleton check #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
commented
Feb 6, 2024
fubuloubu
requested review from
solarthesis and
antazoey
and removed request for
solarthesis
|
@solarthesis just leave an approval if it all works for you now with this PR |
solarthesis
approved these changes
Feb 8, 2024
antazoey
approved these changes
Feb 8, 2024
| @@ -1,6 +1,11 @@ | |||
| # Ape stuff | |||
| .build/ | |||
|
|
|||
| # NPM Stuff | |||
| node_modules/ | |||
| package.json | |||
There was a problem hiding this comment.
does package.json get generated? It isn't a typical file to exclude, that is why I am asking
There was a problem hiding this comment.
yeah, from ape configured to install the safe contract dependency (which is the source of the info)
otherwise it will probably get touched for every variation of the safe contracts we test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Noticed that the bytecode we were using did not properly match when it was deployed to an alternative network
fixes: #27
How I did it
How to verify it
Checklist
- [ ] New test cases have been added and are passing- [ ] Documentation has been updated