generated from ApeWorX/project-template
-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ape compile source import references #36
Merged
NotPeopling2day
merged 14 commits into
ApeWorX:main
from
NotPeopling2day:fix/ape-compile
May 25, 2022
Merged
fix: ape compile source import references #36
NotPeopling2day
merged 14 commits into
ApeWorX:main
from
NotPeopling2day:fix/ape-compile
May 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Type-check currently doesn't pass because of a method I'm adding in core. I'm planning on sharing that logic between the different compilers to lookup the filename in the given paths. |
antazoey
reviewed
May 17, 2022
antazoey
reviewed
May 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test cases that would be nice:
- Relative imports from same directory
- Relative imports when going up a directory (
../
) - Imports that are part of a remapping (?)
This is looking good! What is missing? |
fubuloubu
approved these changes
May 23, 2022
antazoey
reviewed
May 25, 2022
antazoey
reviewed
May 25, 2022
def test_get_import_remapping(compiler, project, config):
import_remapping = compiler.get_import_remapping()
with config.using_project(project.path / "dependency"):
# Should be different now that we have changed projects.
second_import_remapping = compiler.get_import_remapping()
assert import_remapping != second_import_remapping |
1 similar comment
def test_get_import_remapping(compiler, project, config):
import_remapping = compiler.get_import_remapping()
with config.using_project(project.path / "dependency"):
# Should be different now that we have changed projects.
second_import_remapping = compiler.get_import_remapping()
assert import_remapping != second_import_remapping |
antazoey
reviewed
May 25, 2022
antazoey
reviewed
May 25, 2022
antazoey
approved these changes
May 25, 2022
This was referenced Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added logic for fetching referenced imports
partial fix for ApeWorX/ape#623
unblocks @sabotagebeats ApeWorX/ape#81
How I did it
Read each source path and pull out imports
Add cleaned import strings to dictionary
How to verify it
Ape core implementation ApeWorX/ape#730
Checklist