Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pins to be compatible for newest version of eth-rlp #892

Closed
sabotagebeats opened this issue Jul 20, 2022 · 3 comments
Closed

update pins to be compatible for newest version of eth-rlp #892

sabotagebeats opened this issue Jul 20, 2022 · 3 comments
Labels
category: refactor Refactor of existing code or process size: 1 piece Easy, well-defined, quick to accomplish

Comments

@sabotagebeats
Copy link
Contributor

Elevator pitch:

eth-rlp is throwing errors in docker with the 0.2.1 version. this requires a manual update to 0.3.0 which then will build and work, but throws a bunch of errors about dependencies not being the correct version. If we update our pins for the newest versions of all the deps that depend on eth-rlp then we should be able to update the pin for eth-rlp and then this issue shouldn't be a problem in the future.

Value:

eth-rlp won't throw errors anymore and will work in docker without an extra install command.

Dependencies:

eth-rlp and eth-account, may be more.

Design approach:

go through pins and make sure they don't break anything and update them.

Task list:

[ ] update pin for eth-account
[ ] update pin for eth-rlp

Estimated completion date:

next sprint

Design review:

Do not signoff unless:

    1. agreed the tasks and design approach will achieve acceptance, and
    1. the work can be completed by one person within the SLA.
      Design reviewers should consider simpler approaches to achieve goals.

(Please leave a comment to sign off)

@sabotagebeats sabotagebeats self-assigned this Jul 20, 2022
@sabotagebeats sabotagebeats changed the title update pins to be compatible for eth-rlp update pins to be compatible for newest version of eth-rlp Jul 20, 2022
@sabotagebeats
Copy link
Contributor Author

related:
#857
#891

@NotPeopling2day NotPeopling2day added size: 1 piece Easy, well-defined, quick to accomplish category: refactor Refactor of existing code or process labels Aug 8, 2022
@antazoey
Copy link
Member

antazoey commented Sep 3, 2022

We are on eth-rlp 0.3.0 now

@antazoey antazoey closed this as completed Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: refactor Refactor of existing code or process size: 1 piece Easy, well-defined, quick to accomplish
Projects
None yet
Development

No branches or pull requests

3 participants