Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove RUN pip install eth-rlp==0.3.0 from dockerfile (blocked) #894

Closed
2 tasks
sabotagebeats opened this issue Jul 20, 2022 · 4 comments
Closed
2 tasks
Labels
category: refactor Refactor of existing code or process size: 1 piece Easy, well-defined, quick to accomplish

Comments

@sabotagebeats
Copy link
Contributor

Elevator pitch:

this line shouldn't need to be here but is because of a dependency mismatch. if we can resolve that by updating the pins then we can remove that line. This work item is to track that.

Value:

cleaner dockerfile, faster build time for docker

Dependencies:

related: #891
blocked by: #892

Design approach:

remove that line from dockerfile after pins have been updated

Task list:

Estimated completion date: next sprint

Design review:

Do not signoff unless:

    1. agreed the tasks and design approach will achieve acceptance, and
    1. the work can be completed by one person within the SLA.
      Design reviewers should consider simpler approaches to achieve goals.

(Please leave a comment to sign off)

@sabotagebeats sabotagebeats self-assigned this Jul 20, 2022
@NotPeopling2day NotPeopling2day added size: 1 piece Easy, well-defined, quick to accomplish category: refactor Refactor of existing code or process labels Aug 8, 2022
@antazoey
Copy link
Member

antazoey commented Sep 2, 2022

I tried putting this in setup.py, as this is the version that gets installed anyway. However - it still fails unless present in the Dockerfile so I was not able to get rid of it.

@antazoey
Copy link
Member

antazoey commented Sep 2, 2022

I am guessing pip install eth-rlp does something magical...

@antazoey
Copy link
Member

antazoey commented Sep 3, 2022

I researched this more.

In site packages, the install of eth-rlp is corrupt. Everything is fine except the __init__.py file is unexpected.
Clearing the install and reinstalling fixes the issue.

However - this smells like an issue somewhere in eth-acount or pyrlp, not in ape.

@antazoey
Copy link
Member

antazoey commented Sep 7, 2022

Was done in python 3.7 removal PR

@antazoey antazoey closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: refactor Refactor of existing code or process size: 1 piece Easy, well-defined, quick to accomplish
Projects
None yet
Development

No branches or pull requests

3 participants