Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: utilize ImpersonatedAccount for contract transactions #1242

Merged
merged 3 commits into from
Jan 28, 2023
Merged

feat: utilize ImpersonatedAccount for contract transactions #1242

merged 3 commits into from
Jan 28, 2023

Conversation

bilbeyt
Copy link
Contributor

@bilbeyt bilbeyt commented Jan 23, 2023 •
edited by NotPeopling2day
Loading

What I did

Implemented support for ImpersonatedAccount to send transaction if account is actually a contract.

fixes: APE-488
fixes: APE-163
fixes: #462

How I did it

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

fubuloubu
fubuloubu reviewed Jan 23, 2023
View reviewed changes
src/ape/contracts/base.py Outdated Show resolved Hide resolved
src/ape/api/providers.py Outdated Show resolved Hide resolved
antazoey
antazoey reviewed Jan 24, 2023
View reviewed changes
src/ape/api/providers.py Outdated Show resolved Hide resolved
@bilbeyt bilbeyt force-pushed the feat/utilize_impersonated_account branch 2 times, most recently from 478cc76 to 79331b2 Compare January 24, 2023 09:06
fubuloubu
fubuloubu reviewed Jan 24, 2023
View reviewed changes
src/ape/api/providers.py Outdated Show resolved Hide resolved
antazoey
antazoey reviewed Jan 24, 2023
View reviewed changes
src/ape/api/providers.py Outdated Show resolved Hide resolved
@bilbeyt bilbeyt force-pushed the feat/utilize_impersonated_account branch from 79331b2 to 2a82957 Compare January 26, 2023 09:34
@bilbeyt bilbeyt requested a review from antazoey January 26, 2023 09:35
@fubuloubu fubuloubu changed the title feat: Utilize ImpersonatedAccount for contract transactions feat: utilize ImpersonatedAccount for contract transactions Jan 26, 2023
antazoey
antazoey previously approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, it is a nice default handler. I don't think we are able to test this in Core since we don't have impersonate account for either Geth or EthTester.

but if this is working for you all, then let's ship it.

@bilbeyt bilbeyt force-pushed the feat/utilize_impersonated_account branch from 2a82957 to e755115 Compare January 27, 2023 15:21
@fubuloubu
Copy link
Member

@bilbeyt just update the branch

@antazoey antazoey merged commit e0f7b57 into ApeWorX:main Jan 28, 2023
antazoey pushed a commit to fubuloubu/ape that referenced this pull request Jan 28, 2023
@bilbeyt @antazoey
feat: Utilize ImpersonatedAccount for contract transactions (ApeWorX#…
12ade24 
…1242)
@antazoey antazoey mentioned this pull request Jan 31, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

@antazoey antazoey antazoey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Unable to use AddressType for 'sender'
3 participants
@bilbeyt @fubuloubu @antazoey