Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes for source tracing [APE-972] #1445

Merged
merged 5 commits into from
May 25, 2023

Conversation

antazoey
Copy link
Member

What I did

Fixes several things that came up from people trying to use the source tracing feature....

  1. Add ability to check if compiler supports it (will need this in Coverage feature anyway)
  2. Performance improvement by preventing the calculation of the source traceback more than once in certain situations
  3. Critical issue causing never-ending loop (hanging) when trying to create the source traceback. For this reason, we may want to patch Core ape after this...
  4. Better error when txn hash is not found
  5. Issue where contracts_folder was None when it should not have been (only happened when using normal Python REPLs).
  6. PC values are now present in the source traceback but also requires that ape-vyper PR

How I did it

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@vany365 vany365 changed the title fix: fixes for source tracing fix: fixes for source tracing [APE-972] May 25, 2023
@antazoey
Copy link
Member Author

antazoey commented May 25, 2023

  • tests

@antazoey antazoey enabled auto-merge (squash) May 25, 2023 15:05
@antazoey antazoey merged commit 72c0868 into ApeWorX:main May 25, 2023
@antazoey antazoey deleted the fix/trace-source-fix branch May 25, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants