fix: issue where installed module names scripts would interfere with ape run [APE-1073]
#1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
scripts would interfere with ape runscripts would interfere with ape run [APE-1073]
sabotagebeats
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
ape runwould always run the wrong deploy script after i installed ApePay.i also made an issue there: ApeWorX/ApePay#14
but to fix it in Ape, I can make it ignore existing modules named
scripts, so that is what this PR does.How I did it
remove from both sys module and sys path to get it to work properly. was a pain to figure that out.
How to verify it
ApePaywithout this PR but with this PR it worksChecklist