Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle HTTPError-based not-implemented RPCs and parity-trace detection error handling easement #2080

Merged
merged 2 commits into from
May 9, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented May 9, 2024

What I did

fixes: #2075

How I did it

fixes in 2 spots:

  1. detect APINotImplemented, which is the proper fix
  2. when an unknown exception happens while testing for parity, mark it as non-parity and go for geth. this should prevent future problems like this more.

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey marked this pull request as draft May 9, 2024 01:14
@antazoey antazoey marked this pull request as ready for review May 9, 2024 02:36
@antazoey antazoey changed the title fix: handle all exceptions when attempting trace_transaction fix: handle HTTPError-based not-implemented RPCs and parity-trace detection error handling easement May 9, 2024
@antazoey antazoey merged commit 2fd4240 into ApeWorX:main May 9, 2024
17 checks passed
@antazoey antazoey deleted the fix/ignore-allerr branch May 9, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

post_send_transaction hook crashes on base sepolia
2 participants