Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add .dsv file beside custom environment hook #3

Merged
merged 2 commits into from
May 26, 2021
Merged

add .dsv file beside custom environment hook #3

merged 2 commits into from
May 26, 2021

Conversation

carlossvg
Copy link

@carlossvg carlossvg commented May 26, 2021 •
edited by dejanpan
Loading

This PR cherry-picks 2 commits from eloquent to make it compatible with the optimizations from: ros2/ros2#764

This change is Reviewable

@dirk-thomas @carlossvg
add .dsv file beside custom environment hook (ros2#449)
6c79542 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas @carlossvg
add .dsv file beside custom environment hook (ros2#466)
21168da 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
t0ny-peng
t0ny-peng approved these changes May 26, 2021
View reviewed changes
Copy link

@t0ny-peng t0ny-peng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Carlos. Everything looks good.

@carlossvg carlossvg merged commit 63e25dd into 6-1-5-apex-rviz2 May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0ny-peng t0ny-peng t0ny-peng approved these changes

@jpsamper2009 jpsamper2009 Awaiting requested review from jpsamper2009

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlossvg @t0ny-peng @dirk-thomas