Fixes #24, #25 - validation of optional parameters containing required attributes #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be great if @komidore64, @tstrachota or @thomasmckay could review/test this PR. |
mbacovsky
force-pushed
the
24_required_params
branch
from
7c42f4a
to
e8a8d16
Compare
|
cool deal! ack 🍺 |
|
BATS are green with this patch - http://ci.theforeman.org/job/systest_foreman_hammer_nightly/111/ |
|
Even the not fake BATs are green, @tstrachota: http://ci.theforeman.org/job/systest_foreman_hammer_nightly/112/ |
| tree | ||
| end | ||
| def validate!(parameters) | ||
| errors = validate(params, parameters) |
There was a problem hiding this comment.
what about using values instead of parameters. the params vs parameters might be a bit misleading
|
Nice job overall. Some comments inline |
|
ACK |
Response object has changed parameters in constructor
mbacovsky
force-pushed
the
24_required_params
branch
from
affdb7d
to
5092c89
Compare
|
@iNecas could you please take a look at my new validation attempt (in separate commit that will eventualy get squashed)? |
|
Small suggestions, leaving up to you if incorporating them or not. ACK |
mbacovsky
force-pushed
the
24_required_params
branch
from
278bf7a
to
c1bd32c
Compare
|
Thanks @iNecas! I'll rerun BATs and merge if green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #24 and #25.
As a bonus I've added extra commit allowing to disable validation per call.