Hopefully the final fix for Rails 5 compatibility #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since rails deprecated some behavior that the old code depended on, we just change it to match what its been doing under the hood all along and avoid having to do a depth first search at the same time.
|
roses and red 🔴 |
Closed
It's not in our power to keep compatibility with ralis 3, 4 and 5 anymore. 3.2 needs to go out
This was referenced Feb 17, 2017
|
apipie-rails-0.4.0 was released, including this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #415
Fixes Issue #495
Fixes Issue #510
Related to PR #465 and #526
Kudos to @aminariana and @sblackstone