Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore_parent_gesture #660

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

q200892907
Copy link
Contributor

Solve the focus problem caused by monitoring onFocusChange and change to monitoring click events

2024-01-10.11.24.14.mov

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (49575bc) 76.78% compared to head (9bcced4) 76.48%.
Report is 5 commits behind head on main.

Files Patch % Lines
...t/base_component/widget/ignore_parent_gesture.dart 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
- Coverage   76.78%   76.48%   -0.31%     
==========================================
  Files         293      295       +2     
  Lines       12969    13041      +72     
==========================================
+ Hits         9958     9974      +16     
- Misses       3011     3067      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 changed the title fix:ignore_parent_gesture fix: ignore_parent_gesture Jan 10, 2024
@LucasXu0 LucasXu0 merged commit 26c24ec into AppFlowy-IO:main Jan 10, 2024
8 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Jan 11, 2024
* main:
  chore: bump version 2.3.0 (AppFlowy-IO#668)
  fix: support character deletion while holding down the Shift key. (AppFlowy-IO#659)
  fix: solve the focus problem caused by monitoring onFocusChange and change to monitoring click events (AppFlowy-IO#660)
@q200892907 q200892907 deleted the fix-ignore_parent_gesture branch January 12, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants