Require external packages only if they are dependencies of the generated binary #197
Conversation
| find_package(zsync2 REQUIRED) | ||
| find_package(libappimage REQUIRED) | ||
| find_package(Qt5 REQUIRED COMPONENTS Core Widgets) | ||
| set(APPIMAGE_UPDATE_USE_SYSTEM_ZSYNC2 @USE_SYSTEM_ZSYNC2@) |
There was a problem hiding this comment.
I think we don't even need those temporary variables. Also, as said before, I'm missing some unset calls here, and I'd give the variables a prefix.
I think using boolean generator expressions, though, we don't need any of these variables:
if($<BOOL:${USE_SYSTEM_ZSYNC2}>)The expression will be converted to an integer (0 or 1, depending on the value). The advantage of this solution is that the strings in USE_SYSTEM_ZSYNC2 will not be propagated into a file that is installed later.
There was a problem hiding this comment.
The variables are not meant to be temporary. Instead a would like to inform libappimageupdate clients how it was built.
There was a problem hiding this comment.
These should be documented in the README then, I guess, and maybe also in this file.
Please use the generator expressions to give the variables uniform values.
Also, please remove the underscore between AppImage and Update. The tool is called "AppImageUpdate" without a space.
Limit
find_packageusage to dependencies that were linked to the binary.Export variables prefixed with
APPIMAGE_UPDATE_to inform clients on how the binary was builtFix of: #195