Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/inherit_c_flags #2

Merged
merged 1 commit into from
Sep 17, 2019
Merged

fix/inherit_c_flags #2

merged 1 commit into from
Sep 17, 2019

Conversation

tiandrew
Copy link
Contributor

@tiandrew tiandrew commented Sep 17, 2019 •
edited
Loading

Not sure if objectVersion needs to be updated

@thomasmso
Copy link
Member

Can you do it for Swift too

@tiandrew
Copy link
Contributor Author

Yea, when I push out the Swift project for phase 2 I'll make sure it's fixed, as of now the swift proj isn't in the repo at all

@tiandrew tiandrew merged commit 81ac0b2 into master Sep 17, 2019
@tiandrew tiandrew deleted the fix/inherit_c_flags branch September 17, 2019 22:46
@Murphy-zhu Murphy-zhu mentioned this pull request Feb 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santoshbagadi santoshbagadi santoshbagadi approved these changes

@thomasmso thomasmso Awaiting requested review from thomasmso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiandrew @thomasmso @santoshbagadi