New implementation of Search API #2981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scripts helps to: - install SolrCloud; - configure it to use Zookeeper of deployment; - create "appscale-search-api-config" config set in Solr; - enable and start Solr service.
- antlr4 grammar was added; - appscale syntax tree preprocessor was added; - build script for compiling antlr4 parser was added.
- Number of models corresponds to GAE Search API objects; - Others helper models represent Solr objects.
- solr_api takes care of communication with SolrCloud; - constants were also added.
- Solr Adapter implements functionality of Search API using Solr. - query_convertor could be a part of solr_adapter but this chunk of functionality worth own module.
- api_methods takes care of protobuf serialization-deserialization; - *.proto files contains protocol definitions.
- search_server is main module of SearchService2; - ensure_searchservice2.sh takes care of compilation of protocols and grammar and installs search package.
Also added support for multiple search_ip addresses.
- use /etc/appscale/search2_ips for storing Search2 locations; - fail during runtime if Solr 7.6 is not installed; - raise client error if feature is not supported; - use nargs='+' for zk-locations argument;
cdonati
approved these changes
Jan 29, 2019
|
Daily build 5880 is run against:
All these PRs should go together |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You could already hear something about SearchService2..
Current orchestration implementation is temporary, that's why you can see some hardcoded values in AppController. It's going to be changed to orchestration model similar to what we have for Datastore.
Related PRs will be referred later (new role in appscale-tools, hawkeye tests and another AppScalefile template to be tested with hawkeye).
Depends on:
Regression tests: