Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check gcmResp before retrying after sendHTTP failure #22

Merged
merged 1 commit into from
Dec 30, 2018
Merged

Check gcmResp before retrying after sendHTTP failure #22

merged 1 commit into from
Dec 30, 2018

Conversation

edaniels
Copy link

A nil panic comes up every so often when sendHTTP fails before it gets a chance to assign the gcmResp value.

@edaniels
Copy link
Author

By the way, if you want a maintainer for this repo, I'm happy to take it over.

@froodian
Copy link
Member

thanks - we use the omitRetry option internally so we haven't run into this but lgtm

@froodian froodian merged commit 0e17f7a into Appboy:master Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edaniels @froodian